yahoo-eng-team team mailing list archive

[Beth Elwell <e.r.elwell@xxxxxxxxx>]

Public bug reported:

Description of problem:

Can not choose flavor in dashboard if glance.min_disk > flavor.disk

Version-Release number of selected component (if applicable):

python-django-horizon-8.0.1-6.el7ost.noarch

How reproducible:

100%

Steps to Reproduce:
1. Create a flavor with Root Disk (GB) = 0
2. Create an image with Minimum Disk (GB) = 1
3. Launch instance and select the image we created in step2.
4. We can not select the flavor we created in step 1 and it is showing grey.

Actual results:

Horizon is making an unnecessary check.

https://github.com/openstack/horizon/blob/stable/liberty/horizon/static/horizon/js/horizon.quota.js#L150

https://github.com/openstack/horizon/blob/stable/liberty/horizon/static/horizon/js/horizon.quota.js#L86

https://github.com/openstack/horizon/blob/stable/liberty/horizon/static/horizon/js/horizon.quota.js#L78

Expected results:

We should be able to launch instance even though glance.min_disk >
flavor.disk.

Additional info:

There is no problem if we launch instance from command line.

In /usr/lib/python2.7/site-packages/nova/compute/api.py

 736             # NOTE(johannes): root_gb is allowed to be 0 for legacy reasons
 737             # since libvirt interpreted the value differently than other
 738             # drivers. A value of 0 means don't check size.

 744                 if image_min_disk > dest_size:
 745                     raise exception.FlavorDiskSmallerThanMinDisk(
 746                         flavor_size=dest_size, image_min_disk=image_min_disk)

We can see that if the root_gb is 0, then nova will not check the disk
size. But Horizon seems to be still checking even though the root_gb is
0. Horizon should take care of this situation when root_gb == 0.

** Affects: horizon
     Importance: Undecided
     Assignee: Beth Elwell (bethelwell)
         Status: New

** Changed in: horizon
     Assignee: (unassigned) => Beth Elwell (bethelwell)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1677206

Title:
  Can not choose flavor in dashboard if glance.min_disk > flavor.disk

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Description of problem:

  Can not choose flavor in dashboard if glance.min_disk > flavor.disk

  Version-Release number of selected component (if applicable):

  python-django-horizon-8.0.1-6.el7ost.noarch

  How reproducible:

  100%

  Steps to Reproduce:
  1. Create a flavor with Root Disk (GB) = 0
  2. Create an image with Minimum Disk (GB) = 1
  3. Launch instance and select the image we created in step2.
  4. We can not select the flavor we created in step 1 and it is showing grey.

  Actual results:

  Horizon is making an unnecessary check.

  https://github.com/openstack/horizon/blob/stable/liberty/horizon/static/horizon/js/horizon.quota.js#L150

  https://github.com/openstack/horizon/blob/stable/liberty/horizon/static/horizon/js/horizon.quota.js#L86

  https://github.com/openstack/horizon/blob/stable/liberty/horizon/static/horizon/js/horizon.quota.js#L78

  Expected results:

  We should be able to launch instance even though glance.min_disk >
  flavor.disk.

  Additional info:

  There is no problem if we launch instance from command line.

  In /usr/lib/python2.7/site-packages/nova/compute/api.py

   736             # NOTE(johannes): root_gb is allowed to be 0 for legacy reasons
   737             # since libvirt interpreted the value differently than other
   738             # drivers. A value of 0 means don't check size.

   744                 if image_min_disk > dest_size:
   745                     raise exception.FlavorDiskSmallerThanMinDisk(
   746                         flavor_size=dest_size, image_min_disk=image_min_disk)

  We can see that if the root_gb is 0, then nova will not check the disk
  size. But Horizon seems to be still checking even though the root_gb
  is 0. Horizon should take care of this situation when root_gb == 0.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1677206/+subscriptions