← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1675536] Re: api-ref: attach volume volumeAttachment description is wrong

 

Reviewed:  https://review.openstack.org/449302
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=dbd1efd74452d3daa6b2d72bec2b1e5f6e6a6d20
Submitter: Jenkins
Branch:    master

commit dbd1efd74452d3daa6b2d72bec2b1e5f6e6a6d20
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Thu Mar 23 16:00:46 2017 -0400

    api-ref: fix description of volumeAttachment for attach/swap-volume
    
    The description of the volumeAttachment request parameter was actually
    the description of the response parameter, which included more fields
    than we allow on the POST and PUT requests for os-volume_attachments.
    
    This fixes the descriptions for both POST and PUT and also includes a
    tiny fix for the wording on the existing volumeAttachment parameter.
    
    Change-Id: I4ccd4ac12e24b232925875fdb5fb568c2bfaf417
    Closes-Bug: #1675536


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1675536

Title:
  api-ref: attach volume volumeAttachment description is wrong

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  https://developer.openstack.org/api-ref/compute/?expanded=attach-a
  -volume-to-an-instance-detail#attach-a-volume-to-an-instance

  That says:

  volumeAttachment        body    object  A dictionary representation of
  a volume attachment containing the fields, device, id, serverId,
  volumeId.

  But there are only two possible fields for that dictionary, volumeId
  (required) and device (optional):

  https://github.com/openstack/nova/blob/b2b366aa4aa2b5199ddbd8cd51019f3d8b7bccc3/nova/api/openstack/compute/schemas/volumes.py#L70

  So the volumeAttachment in the request parameters here are probably
  actually for a response which has those other details like id and
  serverId.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1675536/+subscriptions


References