yahoo-eng-team team mailing list archive

[OpenStack Infra <1674780@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/447679
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9ee58550e0db2b96eef982621a6a3715a285fb6c
Submitter: Jenkins
Branch:    master

commit 9ee58550e0db2b96eef982621a6a3715a285fb6c
Author: Ihar Hrachyshka <ihrachys@xxxxxxxxxx>
Date:   Mon Mar 20 20:36:29 2017 +0000

    Write vrrp_script before (re)starting keepalived
    
    Otherwise if keepalived decides to trigger the script before we write it
    out, or when we fail to generate the script, then the router may become
    broken.
    
    Closes-Bug: 1674780
    Change-Id: I2cea3159fd84c40506254fbd688cb1d745c9bf1c


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1674780

Title:
  L3 HA: check scripts are written after keepalived is (re)started

Status in neutron:
  Fix Released

Bug description:
  Code inspection showed that L3 HA implementation outputs config file
  for keepalived; then (re)starts the daemon, and only then attempts to
  write check scripts. It is a race condition vector that would show up
  if it would take it longer for the agent to write the check scripts;
  or if the agent would fail to write them at all due to some other bug.
  In which case, the daemon and the router may have fallen back to
  backup state.

  We should first prepare all files, then (re)start keepalived.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1674780/+subscriptions