← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1680116] [NEW] ds-identify needs to support check_instance_id like function

 

Public bug reported:

When ds-identify runs, it identifies the cloud platform based on available information.
For some datasources provided as an attached disk, the cloud provider may remove that disk at some time (or potentially, the user might destroy it).  In such cases (Azure and ConfigDrive) the system id read from smbios is the same as the instance-id, so we can locally quickly check.

cloud-init's datasource search code supports this via the 'check_instance_id' method in a datasource.
Basically, that function is called from the old datasource.  If it retunrs true, then cloud-init would not go looking for an attached disk that it would not find.

The ds-identify code does not support this at the moment.  The result is if you did:
 * boot system with configdrive
 * dd if=/dev/zero of=/dev/disk/by-name/config-2
 * reboot

ds-identify would then not recognize this system as config drive even
though the datasource would recognize it was.

** Affects: cloud-init
     Importance: High
         Status: Triaged


** Tags: dsid

** Changed in: cloud-init
       Status: New => Triaged

** Changed in: cloud-init
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1680116

Title:
  ds-identify needs to support check_instance_id like function

Status in cloud-init:
  Triaged

Bug description:
  When ds-identify runs, it identifies the cloud platform based on available information.
  For some datasources provided as an attached disk, the cloud provider may remove that disk at some time (or potentially, the user might destroy it).  In such cases (Azure and ConfigDrive) the system id read from smbios is the same as the instance-id, so we can locally quickly check.

  cloud-init's datasource search code supports this via the 'check_instance_id' method in a datasource.
  Basically, that function is called from the old datasource.  If it retunrs true, then cloud-init would not go looking for an attached disk that it would not find.

  The ds-identify code does not support this at the moment.  The result is if you did:
   * boot system with configdrive
   * dd if=/dev/zero of=/dev/disk/by-name/config-2
   * reboot

  ds-identify would then not recognize this system as config drive even
  though the datasource would recognize it was.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1680116/+subscriptions


Follow ups