← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1670409] Re: Experimental E-M-C migrations broken

 

Reviewed:  https://review.openstack.org/440875
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=15817166ab35212069517ba0002d8098988fd3bd
Submitter: Jenkins
Branch:    master

commit 15817166ab35212069517ba0002d8098988fd3bd
Author: Alexander Bashmakov <alexander.bashmakov@xxxxxxxxx>
Date:   Thu Mar 2 23:40:16 2017 +0000

    Fix experimental E-M-C migrations
    
    Two closely related issues were discovered in the code which prevent
    the experimental E-M-C (rolling upgrade) migration feature introduced
    in Ocata from working: a malformed select statement in the ocata
    community images data migration (missing function parentheses)
    and an incorrect revision dependency in the DB migration (should be
    'ocata_expand01' instead of 'expand'. Also added a test for the case
    where the Glance database is new/empty which illuminated this bug.
    
    Closes-Bug: 1670409
    Change-Id: I40ffaaa3fa2bae7a555a86d9f31422d79fb9bb19


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1670409

Title:
  Experimental E-M-C migrations broken

Status in Glance:
  Fix Released

Bug description:
  Glance Experimental Expand-Migrate-Contract feature introduced in
  Ocata release is currently broken due to couple of bugs in the code:

  https://github.com/openstack/glance/blob/master/glance/db/sqlalchemy/alembic_migrations/data_migrations/ocata_migrate01_community_images.py#L43
  - malformed select statement

  and

  https://github.com/openstack/glance/blob/master/glance/db/sqlalchemy/alembic_migrations/versions/ocata_contract01_drop_is_public.py#L30
  - incorrect revision dependency

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1670409/+subscriptions


References