← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1680616] [NEW] instance_get_all_by_host joins tables even if told not to

 

Public bug reported:

The instance_get_all_by_host DB API will join the info_cache and
security_groups tables even if told not to by passing in
columns_to_join=[], which the _sync_instance_scheduler_info periodic
task from the compute manager does.

That is because instance_get_all_by_host doesn't pass columns_to_join
through to _instance_get_all_query which will default to join on
info_cache and security_groups:

https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/db/sqlalchemy/api.py#L2530

https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/db/sqlalchemy/api.py#L2513

** Affects: nova
     Importance: Medium
     Assignee: Matt Riedemann (mriedem)
         Status: Confirmed


** Tags: db

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1680616

Title:
  instance_get_all_by_host joins tables even if told not to

Status in OpenStack Compute (nova):
  Confirmed

Bug description:
  The instance_get_all_by_host DB API will join the info_cache and
  security_groups tables even if told not to by passing in
  columns_to_join=[], which the _sync_instance_scheduler_info periodic
  task from the compute manager does.

  That is because instance_get_all_by_host doesn't pass columns_to_join
  through to _instance_get_all_query which will default to join on
  info_cache and security_groups:

  https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/db/sqlalchemy/api.py#L2530

  https://github.com/openstack/nova/blob/6103ec7c113121866344cdca2fbbbf7b80dfa975/nova/db/sqlalchemy/api.py#L2513

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1680616/+subscriptions


Follow ups