← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1677742] Re: Missing Binary Commands don't log in a sane way

 

Reviewed:  https://review.openstack.org/453278
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0476ad641dffb4cdcb6fb72e9dd6579ffc21b754
Submitter: Jenkins
Branch:    master

commit 0476ad641dffb4cdcb6fb72e9dd6579ffc21b754
Author: Brian Haley <bhaley@xxxxxxxxxx>
Date:   Tue Apr 4 13:54:42 2017 -0400

    Print useful error on rootwrap daemon failure
    
    If the rootwrap daemon fails to execute a command, it
    generates a cryptic message:
    
    Unserializable message: ('#ERROR', ValueError('I/O operation on closed file',))
    
    We should at least log the command that we were trying
    to run, which will help users figure out why it failed.
    
    Change-Id: I2c94e5a226630432028351f8287868f4fe5d2fa1
    Closes-bug: #1677742


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1677742

Title:
  Missing Binary Commands don't log in a sane way

Status in neutron:
  Fix Released

Bug description:
  When running neutron in an environment with a missing binary command
  run by a linux agent the failure mode is far from clear. For example:

  http://paste.openstack.org/show/604877/

  
  Is what was logged on my system when I didn't have ipset installed. It's not clear at all from this error message or stack trace that was the cause of failure. The only way I was able to figure this out was to switch the default rootwrap-daemon config file to DEBUG level and use syslog to actually see the missing executable error message.

  You shouldn't need to modify the default log levels to see the cause
  of a fatal error like a missing binary command.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1677742/+subscriptions


References