yahoo-eng-team team mailing list archive

[OpenStack Infra <1659290@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/433872
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=453e8064a531197ca26b020474049afff40ba969
Submitter: Jenkins
Branch:    master

commit 453e8064a531197ca26b020474049afff40ba969
Author: Trevor McCasland <TM2086@xxxxxxx>
Date:   Tue Feb 14 13:10:27 2017 -0600

    Exit on failure to load mechanism drivers
    
    By using the on_missing_entrypoints_callback and
    on_load_failure_callback options[1] we can call a handler for the
    missing driver error properly.
    
    As the bug states, I logged it as a critical failure and terminated
    the neutron server.
    
    I used SystemExit, I wasn't sure if there was a more graceful way
    of exiting.
    
    [1] http://docs.openstack.org/developer/stevedore/managers.html
    
    Change-Id: Id18afd159d0b0ada0cc36964dd9c1ebe7a1cd94b
    Closes-Bug: #1659290


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1659290

Title:
  Failure to load mechanism drivers in ML2 should be critical

Status in neutron:
  Fix Released

Bug description:
  Right now when ML2 load mechanism driver, if some of them is
  unavailable (due to typo or bug in the driver, preventing it to be
  loaded by stevedore), it registered only in 'info' output of neutron-
  server ('Configured mechanism driver names' and 'Loaded mechanism
  driver names').

  I believe inability to initialize any on given mechanism drivers is
  grave and fatal for neutron server. Server without proper mechanism
  driver will silently made all relevant port bindings 'binding_failed',
  causing harm and chaos in production environment.

  Proposition:

  terminate neutron-server with CRITICAL failure if some of
  cfg.CONF.ml2.mechanism_drivers is unavailable.

  This is a big issue for operators, because, currently, such
  misconfigurations are REALLY hard to debug, especially in conjuncture
  with broken mechanism drivers.

  Affected version: master

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1659290/+subscriptions