yahoo-eng-team team mailing list archive

[OpenStack Infra <1682307@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/456419
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=27d18ac5c5205604243ef50305e1ba40979551ca
Submitter: Jenkins
Branch:    master

commit 27d18ac5c5205604243ef50305e1ba40979551ca
Author: Joe Talerico <jtaleric@xxxxxxxxxx>
Date:   Wed Apr 12 20:14:59 2017 -0400

    Don't override default values for oslo.db options
    
    This change will make neutron-server use default values from oslo.db if
    any of them are not overridden in config files, instead of applying its
    own unique values that may be unexpected to users and operators.
    
    It also makes our config files correct since now we don't claim wrong
    values being default. (Remember the config generator was never aware of
    our snowflake behaviour.)
    
    If you wonder why we were overriding it in the first place, it was
    needed back in the times when we were using db module from
    oslo-incubator that has not provided proper defaults. Those times are
    long gone.
    
    Of course the change is not impact free, and operators who for some
    reason want to keep the old values may need to adjust their
    configuration files. Still, I believe using default values from oslo.db
    is the correct thing to do long term.
    
    We still need to set connection string for unit tests to sqlite:// since
    oslo.db doesn't provide any default value for the option. It should be
    fine to effectively unset default value for the option for
    neutron-server since no one in production can use sqlite anyway.
    
    This change also drops set_db_defaults function from
    neutron.common.config. I have checked that there are no consumers for
    the function outside the tree.
    
    NeutronLibImpact
    UpgradeImpact
    
    Co-Authored-By: Ihar Hrachyshka <ihrachys@xxxxxxxxxx>
    Change-Id: Ia97d6cf24e554f7b3878dd301ae4e7e10a1c9998
    Closes-Bug: #1682307


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1682307

Title:
  overwriting oslo.db defaults

Status in neutron:
  Fix Released

Bug description:
  oslo.db sets the max_overflow to 50 by default, however Neutron
  common/config.py overwrites that with 20.

  Version: Ocata

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1682307/+subscriptions