← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1672213] Re: 'True' is displayed in "Admin State" choice field when editing a port

 

Reviewed:  https://review.openstack.org/444670
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c8cd03189a7ea38ebdd97d613a88a50d255005c2
Submitter: Jenkins
Branch:    master

commit c8cd03189a7ea38ebdd97d613a88a50d255005c2
Author: Akihiro Motoki <motoki@xxxxxxxxxxxxx>
Date:   Sun Mar 12 20:55:20 2017 +0000

    Use BooleanField for admin_state_up form
    
    admin_state_up is a boolean value but the network and port edit forms
    expected a string version of True/False. As a result, True/False string
    was shown as the default value in these forms. The field is implemented
    as ChoiceField, but there is no special reason not to use BooleanField
    for a boolean field and admin_state(_up) fields are the only exceptions
    in horizon. This commit replaces all admin_state(_up) fields to
    use BooleanField.
    
    As far as I checked, this pattern is used only in the networking
    related panels and this patch clean them up.
    
    Change-Id: I9286f6c29d67fec7a88b74661bc8eca945fd9061
    Closes-Bug: #1672213


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1672213

Title:
  'True' is displayed in "Admin State" choice field when editing a port

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The choice of Admin State field for a port is UP or DOWN, but "True"
  is displayed when the Edit Port form is displayed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1672213/+subscriptions


References