yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem.os@xxxxxxxxx>]

Yeah the os-brick method is returning a 2-item tuple now instead of a
list. That's fine since it's an internal method to os-brick, and the
unit test in nova should be moved to os-brick (it's legacy code from
when nova was changed to use os-brick for the libvirt driver, not all of
the unit tests were moved over). In fact, there is even a todo in the
test code to move it to os-brick.

** Changed in: os-brick
       Status: New => Invalid

** Changed in: nova
       Status: New => Triaged

** Changed in: nova
     Assignee: (unassigned) => Matt Riedemann (mriedem)

** Changed in: nova
   Importance: Undecided => High

** Changed in: os-brick
       Status: Invalid => New

** Changed in: os-brick
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1672670

Title:
  Unit tests fail with current os-brick master

Status in OpenStack Compute (nova):
  In Progress
Status in os-brick:
  Invalid

Bug description:
  When running Nova unit tests using the current os-brick from master,
  nova.tests.unit.virt.libvirt.volume.test_iscsi.LibvirtISCSIVolumeDriverTestCase.test_iscsiadm_discover_parsing
  fails .

  How to reproduce:

  1- setup virtualenv with Nova test-requirements
  2- pip install --upgrade git+https://github.com/openstack/os-brick
  3- ostestr -r  nova.tests.unit.virt.libvirt.volume.test_iscsi.LibvirtISCSIVolumeDriverTestCase.test_iscsiadm_discover_parsing

  Got the following traceback:

  nova.tests.unit.virt.libvirt.volume.test_iscsi.LibvirtISCSIVolumeDriverTestCase.test_iscsiadm_discover_parsing
  --------------------------------------------------------------------------------------------------------------

  Captured traceback:
  ~~~~~~~~~~~~~~~~~~~
      Traceback (most recent call last):
        File "nova/tests/unit/virt/libvirt/volume/test_iscsi.py", line 47, in test_iscsiadm_discover_parsing
          self.assertEqual(targets, out)
        File "/tmp/venv/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
          self.assertThat(observed, matcher, message)
        File "/tmp/venv/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
          raise mismatch_error
      testtools.matchers._impl.MismatchError: !=:
      reference = [['192.168.204.82:3260,1',
        'iqn.2010-10.org.openstack:volume-f9b12623-6ce3-4dac-a71f-09ad4249bdd3'],
       ['192.168.204.82:3261,1',
        'iqn.2010-10.org.openstack:volume-f9b12623-6ce3-4dac-a71f-09ad4249bdd4']]
      actual    = (['192.168.204.82:3260,1', '192.168.204.82:3261,1'],
       ['iqn.2010-10.org.openstack:volume-f9b12623-6ce3-4dac-a71f-09ad4249bdd3',
        'iqn.2010-10.org.openstack:volume-f9b12623-6ce3-4dac-a71f-09ad4249bdd4'])

  https://review.openstack.org/433104 looks like the most probable
  cause.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1672670/+subscriptions