yahoo-eng-team team mailing list archive

[Brian Rosmaita <rosmaita.fossdev@xxxxxxxxx>]

Public bug reported:

Here's the situation.

There was a discussion during the Newton-Ocata time frame about whether
glance supports custom location_strategy modules.  We decided that it
does not, and at that time used the 'choices' parameter in the
location_strategy api config option (defined using oslo.config) to
restrict the names the option could take to the two location strategy
modules that come with glance.  There's code that checks to make sure
the module set by the config module actually exists.  We had a test for
this that used an override in oslo.config to set the location_strategy
option to something like 'invalid_module' and then tested to make sure
the missing module was handled properly.  In the meantime, oslo.config
has removed the ability to do this kind of override.  So the test has to
be changed.

We don't have bandwidth to get into this right now, so I'm filing this bug to remind us to go back and fix this when someone has time.  Here's the patch that removes the test:
https://review.openstack.org/#/c/457050/

** Affects: glance
     Importance: Medium
         Status: Triaged

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1686764

Title:
  technical debt: replace a location_stragegy test

Status in Glance:
  Triaged

Bug description:
  Here's the situation.

  There was a discussion during the Newton-Ocata time frame about
  whether glance supports custom location_strategy modules.  We decided
  that it does not, and at that time used the 'choices' parameter in the
  location_strategy api config option (defined using oslo.config) to
  restrict the names the option could take to the two location strategy
  modules that come with glance.  There's code that checks to make sure
  the module set by the config module actually exists.  We had a test
  for this that used an override in oslo.config to set the
  location_strategy option to something like 'invalid_module' and then
  tested to make sure the missing module was handled properly.  In the
  meantime, oslo.config has removed the ability to do this kind of
  override.  So the test has to be changed.

  We don't have bandwidth to get into this right now, so I'm filing this bug to remind us to go back and fix this when someone has time.  Here's the patch that removes the test:
  https://review.openstack.org/#/c/457050/

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1686764/+subscriptions