← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1406333] Re: LOG messages localized, shouldn't be

 

Reviewed:  https://review.openstack.org/455635
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ced987815d6a091fbcedbd4c319395038cb3f976
Submitter: Jenkins
Branch:    master

commit ced987815d6a091fbcedbd4c319395038cb3f976
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Tue Apr 11 10:24:01 2017 +0000

    Ensure log messages are not translated
    
    Previously translated messages are included in log messages
    and it was determined what language is chosen by users.
    It makes difficult for operators to understand log messgaes.
    
    This commit tries to use English messages for all log messages.
    The following policies are applied based on the past discussions
    in the bug 1406333 and related reviews.
    
    - English messages are used for log messages.
    - log messages include exception messages if possible
      to help operators identify what happens.
    - Use ID rather than name for log messages
      as ID is much more unique compared to name.
    - LOG.debug() in success code path are deleted.
      We don't log success messages in most places and API calls to
      back-end services can be logged from python bindings.
    
    Change-Id: Ie554463908327435d886d0d0f1671fd327c0cd00
    Closes-Bug: #1406333


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1406333

Title:
  LOG messages localized, shouldn't be

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  LOG messages should not be localized. There are a few places in
  project/firewalls/forms.py that they are. These instances should be
  removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1406333/+subscriptions


References