← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1691546] Re: libvirt: original exception is lost of vif unplug fails during attach_interface error handling

 

Actually nevermind, the original exception would be logged with
traceback before call vif unplug:

https://github.com/openstack/nova/blob/8d492c76d53f3fcfacdd945a277446bdfe6797b0/nova/virt/libvirt/driver.py#L1404

** Changed in: nova
       Status: Triaged => Invalid

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1691546

Title:
  libvirt: original exception is lost of vif unplug fails during
  attach_interface error handling

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  Because we're not using excutils.save_and_reraise_exception here:

  https://github.com/openstack/nova/blob/8d492c76d53f3fcfacdd945a277446bdfe6797b0/nova/virt/libvirt/driver.py#L1405

  If the vif unplug call raises a new exception, we'll lose the original
  exception context from when guest.attach_device failed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1691546/+subscriptions


References