← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1691427] Re: AttributeError: 'DvrLocalRouter' object has no attribute 'ha_state'

 

Reviewed:  https://review.openstack.org/465740
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b748f2e9b9892443cd4ae072f69a26f8af6da2d1
Submitter: Jenkins
Branch:    master

commit b748f2e9b9892443cd4ae072f69a26f8af6da2d1
Author: Brian Haley <bhaley@xxxxxxxxxx>
Date:   Wed May 17 16:51:18 2017 -0400

    DVR: Do not check HA state on DVR-only routers
    
    Trying to check HA state on a DVR-only compute node
    can trigger:
    
    AttributeError: 'DvrLocalRouter' object has no attribute 'ha_state'
    
    Also moved the mode assignment outside of the loops
    since it only needs to be done once.
    
    Co-Authored-By: Sean Redmond <sean.redmond1@xxxxxxxxx>
    Closes-bug: #1691427
    Change-Id: I3e48e06e76325939fbc9533b0198924bc96d600e


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1691427

Title:
  AttributeError: 'DvrLocalRouter' object has no attribute 'ha_state'

Status in neutron:
  Fix Released

Bug description:
  I have noticed the below in the newutron l3 agent log of compute nodes
  running in DVR mode, It seems to log the same message every 60 seconds
  or so. Restarting the agent will stop the log until log rotate is
  called the next day and then the return in the same fashion.

  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task [req-5c48816b-0705-438a-b823-eca41cfe6c35 - - - - -] Error during L3NATAgentWithStateReport.periodic_sync_routers_task
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task Traceback (most recent call last):
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task   File "/usr/lib/python2.7/dist-packages/oslo_service/periodic_task.py", line 220, in run_periodic_tasks
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task     task(self, context)
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task   File "/usr/lib/python2.7/dist-packages/neutron/agent/l3/agent.py", line 552, in periodic_sync_routers_task
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task     self.fetch_and_sync_all_routers(context, ns_manager)
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task   File "/usr/lib/python2.7/dist-packages/osprofiler/profiler.py", line 154, in wrapper
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task     return f(*args, **kwargs)
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task   File "/usr/lib/python2.7/dist-packages/neutron/agent/l3/agent.py", line 586, in fetch_and_sync_all_routers
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task     r['id'], r.get(l3_constants.HA_ROUTER_STATE_KEY))
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task   File "/usr/lib/python2.7/dist-packages/neutron/agent/l3/ha.py", line 120, in check_ha_state_for_router
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task     if ri and current_state != TRANSLATION_MAP[ri.ha_state]:
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task AttributeError: 'DvrLocalRouter' object has no attribute 'ha_state'
  2017-05-17 10:37:10.432 27502 ERROR oslo_service.periodic_task
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task [req-5c48816b-0705-438a-b823-eca41cfe6c35 - - - - -] Error during L3NATAgentWithStateReport.periodic_sync_routers_task
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task Traceback (most recent call last):
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task   File "/usr/lib/python2.7/dist-packages/oslo_service/periodic_task.py", line 220, in run_periodic_tasks
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task     task(self, context)
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task   File "/usr/lib/python2.7/dist-packages/neutron/agent/l3/agent.py", line 552, in periodic_sync_routers_task
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task     self.fetch_and_sync_all_routers(context, ns_manager)
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task   File "/usr/lib/python2.7/dist-packages/osprofiler/profiler.py", line 154, in wrapper
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task     return f(*args, **kwargs)
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task   File "/usr/lib/python2.7/dist-packages/neutron/agent/l3/agent.py", line 586, in fetch_and_sync_all_routers
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task     r['id'], r.get(l3_constants.HA_ROUTER_STATE_KEY))
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task   File "/usr/lib/python2.7/dist-packages/neutron/agent/l3/ha.py", line 120, in check_ha_state_for_router
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task     if ri and current_state != TRANSLATION_MAP[ri.ha_state]:
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task AttributeError: 'DvrLocalRouter' object has no attribute 'ha_state'
  2017-05-17 10:37:50.102 27502 ERROR oslo_service.periodic_task

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1691427/+subscriptions


References