yahoo-eng-team team mailing list archive

[OpenStack Infra <1693536@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/468079
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=34caf71d4a3548560debbba4599cd470317ec5a1
Submitter: Jenkins
Branch:    master

commit 34caf71d4a3548560debbba4599cd470317ec5a1
Author: wei.ying <wei.ying@xxxxxxxxxxxx>
Date:   Thu May 18 11:27:01 2017 +0800

    Remove the duplicate method call when retrieving the instance log
    
    There are two identical ways to get an instance log
    and it should delete the incorrect one.
    
    [0] openstack_dashboard/static/js/horizon.firewalls.js#L24
    [1] openstack_dashboard/static/js/horizon.instances.js#L28
    
    Change-Id: I78641f4a5ddf51f905eed1679bb5552529c85e3e
    Closes-Bug: #1693536


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1693536

Title:
  Repeat method to get instance log

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Env: devstack master branch

  Steps to reproduce:
  1. Go to project/instances panel
  2. Choose an instance and then click its row action View LOG
  3. Click Go button to get instance logs
  4. Viewing the horizon log or the console, you can see the same request for get instance log. 

  Reason： the call is repeated with ［0］ and [1]

  [0]
  https://github.com/openstack/horizon/blob/92f0f23db6afdadafd316df3f323554dd7423752/openstack_dashboard/static/js/horizon.firewalls.js#L24

  [1]
  https://github.com/openstack/horizon/blob/a0d13157e39c452f81d35e7d91a1a9b3a289154a/openstack_dashboard/static/js/horizon.instances.js#L28

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1693536/+subscriptions