yahoo-eng-team team mailing list archive

[Steve Noyes <steve.noyes@xxxxxxxxxx>]

Public bug reported:

While testing live migration, I hit an exception during libvirt.driver
rollback_live_migration_at_destination. The first step is this:

self.destroy(context, instance, network_info, block_device_info,
                         destroy_disks, migrate_data)

But there is no arg in the destroy method for migrate_data:

def destroy(self, context, instance, network_info, block_device_info=None,
                destroy_disks=True):

The tail end of the exception:

  File "/opt/stack/nova/nova/compute/manager.py", line 5896, in rollback_live_migration_at_destination
    destroy_disks=destroy_disks, migrate_data=migrate_data)
  File "/opt/stack/nova/nova/virt/libvirt/driver.py", line 6690, in rollback_live_migration_at_destination
    destroy_disks, migrate_data)
TypeError: destroy() takes at most 6 arguments (7 given)

ubuntu/kvm/pike:

commit 20f47b1a3e8e80e6f9e2373cacc2480404c3cfd9
Merge: c993572 e8afd71
Author: Jenkins <jenkins@xxxxxxxxxxxxxxxxxxxx>
Date:   Wed May 31 16:34:27 2017 +0000

    Merge "Add policy description for os-networks"

** Affects: nova
     Importance: Undecided
         Status: New

** Summary changed:

- libvirt rollback: destory called with wrong number of args
+ libvirt rollback: destroy called with wrong number of args

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1694834

Title:
  libvirt rollback: destroy called with wrong number of args

Status in OpenStack Compute (nova):
  New

Bug description:
  While testing live migration, I hit an exception during libvirt.driver
  rollback_live_migration_at_destination. The first step is this:

  self.destroy(context, instance, network_info, block_device_info,
                           destroy_disks, migrate_data)

  But there is no arg in the destroy method for migrate_data:

  def destroy(self, context, instance, network_info, block_device_info=None,
                  destroy_disks=True):

  The tail end of the exception:

    File "/opt/stack/nova/nova/compute/manager.py", line 5896, in rollback_live_migration_at_destination
      destroy_disks=destroy_disks, migrate_data=migrate_data)
    File "/opt/stack/nova/nova/virt/libvirt/driver.py", line 6690, in rollback_live_migration_at_destination
      destroy_disks, migrate_data)
  TypeError: destroy() takes at most 6 arguments (7 given)

  ubuntu/kvm/pike:

  commit 20f47b1a3e8e80e6f9e2373cacc2480404c3cfd9
  Merge: c993572 e8afd71
  Author: Jenkins <jenkins@xxxxxxxxxxxxxxxxxxxx>
  Date:   Wed May 31 16:34:27 2017 +0000

      Merge "Add policy description for os-networks"

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1694834/+subscriptions