← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1694574] Re: Failed loading flavors in instance launch under MSIE11

 

Reviewed:  https://review.openstack.org/469452
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a1dd0350502fc089dc42157e4692960ca8ec82e0
Submitter: Jenkins
Branch:    master

commit a1dd0350502fc089dc42157e4692960ca8ec82e0
Author: Radomir Dopieralski <openstack@xxxxxxxxxxxx>
Date:   Wed May 31 14:18:23 2017 +0200

    Fix instance launch dialog under MSIE11
    
    The novaAPI.getFlavors() call takes only a single parameter, which
    should be an object with params. But it is being called with two
    parameters here, both "true", which makes IE11 fail with TypeError
    later on, when it tries to iterate over keys of params.
    
    Change-Id: I0dcfcdca3dda2d94509d7a574184e7f82f21ca22
    Closes-Bug: #1694574


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1694574

Title:
  Failed loading flavors in instance launch under MSIE11

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  No flavors are shown in the "Launch Instance" dialog in Internet
  Explorer 11 (IE11).

  Instead, the following alert message is displayed: "Error: Unable to
  retrieve the flavors."

  The following error appears in the console:

      TypeError: Object.keys: argument is not an Object
         at forEachSorted (http://10.124.196.21/dashboard/static/dashboard/js/768aef8292b1.js:705:46)
         at ngParamSerializer (http://10.124.196.21/dashboard/static/dashboard/js/768aef8292b1.js:1201:137)
         at sendReq (http://10.124.196.21/dashboard/static/dashboard/js/768aef8292b1.js:1236:126)
         at serverRequest (http://10.124.196.21/dashboard/static/dashboard/js/768aef8292b1.js:1232:1)
         at processQueue (http://10.124.196.21/dashboard/static/dashboard/js/768aef8292b1.js:1469:243)
         at Anonymous function (http://10.124.196.21/dashboard/static/dashboard/js/768aef8292b1.js:1470:135)
         at Scope.prototype.$eval (http://10.124.196.21/dashboard/static/dashboard/js/768aef8292b1.js:1516:530)
         at Scope.prototype.$digest (http://10.124.196.21/dashboard/static/dashboard/js/768aef8292b1.js:1510:184)
         at Scope.prototype.$apply (http://10.124.196.21/dashboard/static/dashboard/js/768aef8292b1.js:1517:266)
         at Anonymous funct

  With COMPRESS disabled, I was able to get a more readable traceback:

  HTML1300: Navigation occurred.
  File: instances
  JQMIGRATE: Logging is active
  TypeError: Object.keys: argument is not an Object
     at forEachSorted (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:351:3)
     at ngParamSerializer (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:10539:7)
     at sendReq (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:11732:11)
     at serverRequest (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:11571:9)
     at processQueue (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:16383:11)
     at Anonymous function (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:16399:27)
     at Scope.prototype.$eval (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:17682:9)
     at Scope.prototype.$digest (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:17495:15)
     at Scope.prototype.$apply (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:17790:13)
     at Anonymous function (http://192.168.0.199/dash
  JQMIGRATE: jQuery.fn.attr('selected') may use property instead of attribute
  console.trace()
     at migrateWarn (http://192.168.0.199/dashboard/static/horizon/lib/jquery_migrate/jquery-migrate.js:43:5)
     at jQuery.attr (http://192.168.0.199/dashboard/static/horizon/lib/jquery_migrate/jquery-migrate.js:155:4)
     at access (http://192.168.0.199/dashboard/static/horizon/lib/jquery/jquery.js:875:6)
     at attr (http://192.168.0.199/dashboard/static/horizon/lib/jquery/jquery.js:4058:3)
     at renderEmptyOption (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:28838:9)
     at writeNgOptionsValue (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:28883:15)
     at ngModelCtrl.$render (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:31205:9)
     at ngModelWatch (http://192.168.0.199/dashboard/static/horizon/lib/angular/angular.js:27815:9)

  Unfortunately, MSIE truncates the callback just when it gets
  interesting...

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1694574/+subscriptions


References