yahoo-eng-team team mailing list archive

[OpenStack Infra <1674259@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/449416
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=65a2c63acf6b5e9d38ef3caa2928eebcc62486a2
Submitter: Jenkins
Branch:    master

commit 65a2c63acf6b5e9d38ef3caa2928eebcc62486a2
Author: Zhou Jianming <zhoujm_cri@xxxxxxxxxxx>
Date:   Thu Mar 23 11:12:47 2017 +0800

    code comments incorrectness
    
    Closes-Bug: #1674259
    
    Change-Id: I5318bc274832b316c017df087f06bb4254a270e1


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1674259

Title:
  code comments incorrectness

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  I am running OpenStack Mitaka on CentOS7.1 with VMware vSphere 5.5 Enterprise Plus.
  In function get_datastore() of nova/virt/vmwareapi/ds_utils.py file, the following code comments:
        ......
        datastore_ret = session._call_method(vutil,
                                             "get_object_property",
                                             object,
                                             "datastore")
        # If there are no hosts in the cluster then an empty string is returned.
        if not datastore_ret:
            raise exception.DatastoreNotFound()

        ......

  According to context, I think  this comments are incorrectness: 
     1)  We get datastore objects, not hosts object.
     2)  If there are no datastores in the cluster then raise exception, not return an empty string.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1674259/+subscriptions