yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #64671
[Bug 1694753] Re: QosPolicyDbObjectTestCase.test_update_objects failed because it couldn't find a matching object
Reviewed: https://review.openstack.org/469602
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9b809fcc60d7e09b4f79fad0b992d0f27d2a100f
Submitter: Jenkins
Branch: master
commit 9b809fcc60d7e09b4f79fad0b992d0f27d2a100f
Author: Ihar Hrachyshka <ihrachys@xxxxxxxxxx>
Date: Wed May 31 10:15:16 2017 -0700
objects: exclude revision_number from updatable fields
Revision service plugin is the entity that updates the database model
attribute, and we don't allow to modify the attribute on API layer. We
should not allow to explicitly update it on OVO layer either.
This can help with spurious unit test failures that sometimes try to
update revision number and then reuse the same number to fetch the
object. If revision service plugin decides to bump the number during the
test case execution once more, using the old number may yield no
results.
Change-Id: I4666c672223ac38508738b739207f754847c62bc
Closes-Bug: #1694753
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1694753
Title:
QosPolicyDbObjectTestCase.test_update_objects failed because it
couldn't find a matching object
Status in neutron:
Fix Released
Bug description:
2017-05-31 15:22:20.901842 | FAIL: neutron.tests.unit.objects.qos.test_policy.QosPolicyDbObjectTestCase.test_update_objects
2017-05-31 15:22:20.901856 | tags: worker-4
2017-05-31 15:22:20.901894 | ----------------------------------------------------------------------
2017-05-31 15:22:20.901912 | Traceback (most recent call last):
2017-05-31 15:22:20.901946 | File "neutron/tests/base.py", line 115, in func
2017-05-31 15:22:20.901964 | return f(self, *args, **kwargs)
2017-05-31 15:22:20.901992 | File "neutron/tests/unit/objects/test_base.py", line 1747, in test_update_objects
2017-05-31 15:22:20.902013 | self.assertEqual(1, len(new_objs))
2017-05-31 15:22:20.902066 | File "/home/jenkins/workspace/neutron-coverage-ubuntu-xenial/.tox/cover/local/lib/python2.7/site-packages/testtools/testcase.py", line 411, in assertEqual
2017-05-31 15:22:20.902093 | self.assertThat(observed, matcher, message)
2017-05-31 15:22:20.902139 | File "/home/jenkins/workspace/neutron-coverage-ubuntu-xenial/.tox/cover/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
2017-05-31 15:22:20.902155 | raise mismatch_error
2017-05-31 15:22:20.902175 | testtools.matchers._impl.MismatchError: 1 != 0
http://logs.openstack.org/31/469231/2/check/neutron-coverage-ubuntu-
xenial/98cd310/console.html
Of all filters used to match the object that could change in flight is
revision_number. Others cannot change between updates and fetches.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1694753/+subscriptions
References