yahoo-eng-team team mailing list archive

[OpenStack Infra <1695052@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/469960
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=bf0998f853b0d563700ec73ca157b821cee1cafb
Submitter: Jenkins
Branch:    master

commit bf0998f853b0d563700ec73ca157b821cee1cafb
Author: Vladislav Kuzmin <vkuzmin@xxxxxxxxxxxx>
Date:   Thu Jun 1 21:40:52 2017 +0400

    Fix Volume Snapshot tab pagination
    
    horizon/templates/horizon/common/_data_table_pagination.html template
    that responsible for pagination link uses
    "has_prev_data" and "has_more_data" methods.
    These methods available in "snapshots" object that return
    the "openstack_dashboard.dashboards.project.snapshots.SnapshotView"
    (and "openstack_dashboard.dashboards.admin.snapshots.SnapshotView")
    views. In turn, these views inherits from
    "horizon.tables.PagedTableMixin" and "horizon.tables.DataTableView".
    If we look at the chain of inheritance of the "DataTableView" class
    we can see the following inheritance
    MultiTableMixin -> MultiTableView -> DataTableView.
    Class MultiTableMixin has it own "has_prev_data"
    and "has_more_data" methods that in always return "False"
    and bacause of this pagination doesn't work.
    In turn, class PagedTableMixin also has "has_prev_data"
    and "has_more_data" methods. These method returns value from
    self._has_prev_data and self._has_more_data that assigned
    in the original view. Because of this pagination depends
    on multiple inheritance in this case.
    
    Do it for Admin and Project tab.
    
    To test: set 'Items Per Page' in the UI Settings page to a low number.
    
    Change-Id: I08ccc430dd0a5d425a15e824ee0906995b56a425
    Closes-Bug: #1695052


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1695052

Title:
  Pagination doesn't work on the Volume Snapshot tab

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Steps to reproduce:
  - Login as admin
  - Go to admin settings
  - Set "Item Per Page" to 2
  - Create a volume if no volumes are present
  - Create 3 snapshots of a volume via dropdown menu
  - Go to "Volume" -> "Snapshots" tab

  Expected result:
  -Button "Next>>" is displayed

  Actual result:
  -"Next>>" isn't presented

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1695052/+subscriptions