← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1697731] Re: HTML output generation may break horizon plugin unittests

 

Reviewed:  https://review.openstack.org/473909
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4ab2877d1f583203a4e313dddf1a9bfd391ad4c1
Submitter: Jenkins
Branch:    master

commit 4ab2877d1f583203a4e313dddf1a9bfd391ad4c1
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Tue Jun 13 16:31:41 2017 +0000

    HTML test report only when nosehtmloutput is installed
    
    Most horizon plugins import openstack_dashboard.test.settings
    in their test settings, but they do not necessarily have nosehtmloutput
    in test-reqs. Assuming nosehtmloutput potentially breaks plugins tests,
    we check the availability of htmloutput module (from nosehtmloutput)
    and specify --with-html-output option if available.
    
    Change-Id: I62502d28c75f823c47edb9de83932363cc2be99f
    Closes-Bug: #1697731


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1697731

Title:
  HTML output generation may break horizon plugin unittests

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  After merging a patch which generates HTML output report for unit tests [1], trove-dashboard unit test starts to fail.
  Most horizon plugins import openstack_dashboard.test.settings and they do not have nosehtmloutput in their test-requirements.txt necessarily.

  openstack_dashboard.test.settings should consider this case.

  The check for htmloutput module availability looks required.

  [1] https://review.openstack.org/#/c/462407/

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1697731/+subscriptions


References