yahoo-eng-team team mailing list archive

[OpenStack Infra <1696893@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/472500
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=739daaa9555e734b94bef89f4fe1c5159c8fd435
Submitter: Jenkins
Branch:    master

commit 739daaa9555e734b94bef89f4fe1c5159c8fd435
Author: Brian Haley <bhaley@xxxxxxxxxx>
Date:   Thu Jun 8 22:40:19 2017 -0400

    Stop arping when interface gets deleted
    
    It is possible for an interface to be added to a
    router, have arping get started for it in a thread,
    then immediately remove the interface, causing
    arping errors in the l3-agent log.  This concurrent
    deletion should be handled more gracefully by
    just logging a warning on the first detection and
    returning early.
    
    Change-Id: I615b60561b3b7f8c950d5f412fb4cdf7877b98f7
    Closes-bug: #1696893


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1696893

Title:
  Arping code should detect missing interface and return early

Status in neutron:
  Fix Released

Bug description:
  Since arping is spawned in a thread, if a router is added and quickly
  removed from a network, the arping calls could generate errors on the
  second or third loop, for example:

  Exit code: 2; Stdin: ; Stdout: ; Stderr: arping: Device qr-1e77796c-2b
  not available.

  This can happen in this scenario:

  T(0): internal_network_added()
          port plugged
          arping started in thread

  T(1): internal_network_removed()
          port unplugged

  T(2): arping fails
  T(3): arping fails

  An example is in:

  http://logs.openstack.org/02/469602/6/check/gate-tempest-dsvm-neutron-
  linuxbridge-ubuntu-
  xenial/7a048d9/logs/screen-q-l3.txt.gz#_Jun_09_00_23_55_483118

  Just search for qr-1e77796c-2b in the logs before this time.

  The arping code should detect this on a failure, log a warning and
  return early as there is no way to stop the thread once it is spawned.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1696893/+subscriptions