← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1466451] Re: Nova should verify that devname in pci_passthrough_whitelist is not empty

 

> According to https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking:
> "The devname can be a valid PCI device name. The only device names that are supported are those displayed by the Linux utility ifconfig -a and correspond to either a PF or a VF on a vNIC"
> 
> However it's possible to supply an empty string as devname
> e.g. pci_passthrough_whitelist = {"devname": "", "physical_network":"physnet2"}
> 
> It's also possible to have an entry:
> pci_passthrough_whitelist = {"physical_network":"physnet2"}
> which shouldn't be valid.

I'm not sure why this isn't valid. IMO, this equates to a wildcard. We
should test to validate this and perhaps update the docs.

> Nova should verify that devname is not an empty string and that
devname,address or product_id/vendor_id are supplied.



** Changed in: nova
       Status: In Progress => Invalid

** Changed in: nova
     Assignee: Stephen Finucane (stephenfinucane) => (unassigned)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1466451

Title:
  Nova should verify that devname in pci_passthrough_whitelist is not
  empty

Status in OpenStack Compute (nova):
  Invalid

Bug description:
  According to https://wiki.openstack.org/wiki/SR-IOV-Passthrough-For-Networking:
  "The devname can be a valid PCI device name. The only device names that are supported are those displayed by the Linux utility ifconfig -a and correspond to either a PF or a VF on a vNIC"

  However it's possible to supply an empty string as devname
  e.g. pci_passthrough_whitelist = {"devname": "", "physical_network":"physnet2"}

  It's also possible to have an entry:
  pci_passthrough_whitelist = {"physical_network":"physnet2"} 
  which shouldn't be valid.

  Nova should verify that devname is not an empty string and that
  devname,address or product_id/vendor_id are supplied.

  Version
  ======
  python-nova-2015.1.0-4.el7ost.noarch

  Expected result
  =============
  Nova compute should fail to start when specifying an empty string for devname when using physical_network or when not specifying devname,address or product_id/vendor_id

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1466451/+subscriptions


References