← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1698284] Re: precommit of securitygroup/rule is missing necessary info

 

Reviewed:  https://review.openstack.org/476216
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=9e208e90942f9553fde4d1f32b1aa462349dcbda
Submitter: Jenkins
Branch:    master

commit 9e208e90942f9553fde4d1f32b1aa462349dcbda
Author: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
Date:   Thu Jun 15 14:14:01 2017 -0700

    unbreak gate
    
    This patch is squashed patches of the following patch.
    There are several issues to break networking-odl gate,
    which requires several patches. In order to unbreak gate,
    those patches need to be squashed into one.
    
    ---
    devstack: bug workaround 1698129
    
    https://bugs.launchpad.net/devstack/+bug/1698129
    caused jobs breakage.
    Define AGENT_BINARY as bug work around.
    Once it's fixed, revert this patch.
    
    Related-bug: #1698129
    
    ---
    unit: make dummy uuid follow uuid format
    
    test_mechanism_odl_v2 test_sg fails due to update of neutron security
    group ovo because dummy uuid doesn't follow uuid format.
    Make those dummy uuid's follow uuid format.
    This also reveals the hidden bug of test_l3_odl. this patch fixes it.
    
    Closes-bug: #1698221
    ---
    unbreak test_update/delete_floating_ip
    
    test_update/delete_floating_ip tests floating ip, not port.
    So floating ip needs to be mocked. not port.
    
    ---
    unbreak security group with ovo
    
    [1] breaks security group. unbreak it.
    
    [1] https://review.openstack.org/#/c/284738/
    Closes-bug: #1698284
    Depends-On: I6f49f25eb2ad16221357024f45a6bb6175d5cd55
    
    ---
    skip functional test_security_group_update
    
    Due to security group update issue,
    functional test of test_security_group_update doesn't pass.
    skip it until the patch [1] is merged.
    Once the patch is merged, revert this patch.
    
    [1] https://review.openstack.org/#/c/475649/
    
    Change-Id: Ifad6929f7700dd3588bd43a45c978b0e071bf385


** Changed in: networking-odl
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1698284

Title:
  precommit of securitygroup/rule is missing necessary info

Status in networking-odl:
  Fix Released
Status in neutron:
  In Progress

Bug description:
  https://review.openstack.org/#/c/284738/
  breaks mechanism driver. especially networking-odl

  precommit callbacks of security group/security group rule creation are missing necessary info.
  They should pass more info. For example id, egress/ingress_rule as deafult rule.
  Before ovo patch, those information can retrieved from context.session.new.
  However with ovo patch, those newly created orm object is dropped from session as
  NeutronDbObject expung itself when it's created. See neutron.objects.base._detach_db_obj for db relationship.

To manage notifications about this bug go to:
https://bugs.launchpad.net/networking-odl/+bug/1698284/+subscriptions


References