yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #65339
[Bug 1691517] Re: centos7 unit tests fail due to hard coded mkfs.ext4
This bug was fixed in the package cloud-init - 0.7.9-153-g16a7302f-
0ubuntu1~16.10.1
---------------
cloud-init (0.7.9-153-g16a7302f-0ubuntu1~16.10.1) yakkety-proposed; urgency=medium
* New upstream snapshot.
- net: fix reading and rendering addresses in cidr format.
[Dimitri John Ledkov] (LP: #1689346, #1684349)
- disk_setup: udev settle before attempting partitioning or fs creation.
(LP: #1692093)
- GCE: Update the attribute used to find instance SSH keys.
[Daniel Watkins] (LP: #1693582)
- nplan: For bonds, allow dashed or underscore names of keys.
[Dimitri John Ledkov] (LP: #1690480)
- tests: python2.6: fix unit tests usage of assertNone and format.
- tests: update docstring on test_configured_list_with_none
- fix tools/ds-identify to not write None twice.
- tox/build: do not package depend on style requirements.
- tests: ntp: Restructure cc_ntp unit tests. [Chad Smith]
- flake8: move the pinned version of flake8 up to 3.3.0
- tests: Apply workaround for snapd bug in test case. [Joshua Powers]
- RHEL/CentOS: Fix dual stack IPv4/IPv6 configuration. [Andreas Karis]
- disk_setup: fix several issues with gpt disk partitions. (LP: #1692087)
- function spelling & docstring update [Joshua Powers]
- tests: Fix unittest bug in ntp tests. [Joshua Powers]
- tox: move pylint target to 1.7.1
- Fix get_interfaces_by_mac for empty macs (LP: #1692028)
- DigitalOcean: remove routes except for the public interface.
[Ben Howard] (LP: #1681531.)
- netplan: pass macaddress, when specified, for vlans
[Dimitri John Ledkov] (LP: #1690388)
- doc: various improvements for the docs on cc_users_groups.
[Felix Dreissig]
- cc_ntp: write template before installing and add service restart
[Ryan Harper] (LP: #1645644)
- tests: fix cloudstack unit tests to avoid accessing
/var/lib/NetworkManager [Lars Kellogg-Stedman]
- tests: fix hardcoded path to mkfs.ext4 [Joshua Powers] (LP: #1691517)
- Actually skip warnings when .skip file is present.
[Chris Brinker] (LP: #1691551)
- netplan: fix netplan render_network_state signature.
[Dimitri John Ledkov] (LP: #1685944)
- Azure: fix reformatting of ephemeral disks on resize to large types.
(LP: #1686514)
- make deb: Add devscripts dependency for make deb.
Cleanup packages/bddeb. [Chad Smith] (LP: #1685935)
- openstack: fix log message copy/paste typo in _get_url_settings
[Lars Kellogg-Stedman]
- unittests: fix unittests run on centos [Joshua Powers]
- Improve detection of snappy to include os-release and kernel cmdline.
(LP: #1689944)
- Add address to config entry generated by _klibc_to_config_entry.
[Julien Castets] (LP: #1691135)
- sysconfig: Raise ValueError when multiple default gateways are present.
[Chad Smith] (LP: #1687485)
- FreeBSD: improvements and fixes for use on Azure
[Hongjiang Zhang] (LP: #1636345)
- Add unit tests for ds-identify, fix Ec2 bug found.
- fs_setup: if cmd is specified, use shell interpretation.
[Paul Meyer] (LP: #1687712)
- doc: document network configuration defaults policy and formats.
[Ryan Harper]
- doc: Fix name of "uri" key in docs for "cc_apt_configure" module
[Felix Dreissig]
- tests: Enable artful in integration tests [Joshua Powers]
-- Scott Moser <smoser@xxxxxxxxxx> Fri, 26 May 2017 16:08:21 -0400
** Changed in: cloud-init (Ubuntu Yakkety)
Status: Fix Committed => Fix Released
** Changed in: cloud-init (Ubuntu Xenial)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1691517
Title:
centos7 unit tests fail due to hard coded mkfs.ext4
Status in cloud-init:
Fix Committed
Status in cloud-init package in Ubuntu:
Fix Released
Status in cloud-init source package in Xenial:
Fix Released
Status in cloud-init source package in Yakkety:
Fix Released
Status in cloud-init source package in Zesty:
Fix Released
Bug description:
=== Begin SRU Template ===
[Impact]
Unit tests for cloud-init did not run successfully in a centos environment.
This is really just failure of the unit tests.
The fix was to no longer expect /sbin/mkfs.ext4 but to mock the
checking.
[Test Case]
Test of ubuntu package in centos is non-trivial and/or not useful.
The proposed test case is to just run the trunk tests at the
uploaded git commit in a lxc container (the environment that originally
found the issue).
$ lxc launch images:centos/7 c7
$ sleep 10; # let it boot
$ lxc exec c7 -- /bin/sh -xe <<"EOF"
yum install --assumeyes epel-release
yum install --assumeyes pyserial python-argparse python-cheetah python-configobj python-jinja2 python-jsonpatch python-oauthlib python-prettytable python-requests python-six python-pip PyYAML git file e2fsprogs
pip install contextlib2 httpretty mock nose pep8 unittest2
git clone https://git.launchpad.net/cloud-init
cd cloud-init
git checkout 16a7302f
nosetests tests/unittests
EOF
[Regression Potential]
No runtime regression potential.
Unit test only changes.
[Other Info]
Upstream commit at
https://git.launchpad.net/cloud-init/commit/?id=951863c21
=== End SRU Template ===
A recent merge that added a mkfs.ext4 tests has a hard coded location
for the binary of mkfs.ext4. The result is that on centos 7, which has
the command in a different location than Ubuntu, is a failed test:
https://paste.ubuntu.com/24589593/
Steps to reproduce:
lxc launch images:centos/7 c7
lxc exec c7 bash
yum install --assumeyes epel-release
yum install --assumeyes pyserial python-argparse python-cheetah python-configobj python-jinja2 python-jsonpatch python-oauthlib python-prettytable python-requests python-six python-pip PyYAML git file e2fsprogs
pip install contextlib2 httpretty mock nose pep8 unittest2
git clone https://git.launchpad.net/cloud-init
cd cloud-init
nosetests tests/unittests
To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1691517/+subscriptions
References