yahoo-eng-team team mailing list archive

[OpenStack Infra <1700578@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/477557
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ca0f293cb60aa1717cdefed4cbae66a3b2c186b3
Submitter: Jenkins
Branch:    master

commit ca0f293cb60aa1717cdefed4cbae66a3b2c186b3
Author: Mykhailo Dovgal <mdovgal@xxxxxxxxxxxx>
Date:   Mon Jun 26 17:14:25 2017 +0300

    Fix tenant_quota_usages function calls caching
    
    This patch changes type of 'targets' input parameter in
    tenant_quota_usages function from list -> tuple. It provides
    possibility for @memoized decorator to cache function calls.
    
    Change-Id: I3c32c3b65ae91e8487fda6148f259fe1931d7c9f
    Closes-Bug: #1700578


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1700578

Title:
  Error during tenant_quota_usages function calls @memoized cache

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  tenant_quota_usages method here [0] accept list as an input parameter.
  Due to list is not immutable object, it couldn't be cached buy @memoized decorator but still method is covered by it.
  Every call of this function triggers UnhashableKeyWarning here [1].

  [0] -
  https://github.com/openstack/horizon/blob/359467b4013bb4f89a6a1309e6eda89459288986/openstack_dashboard/usage/quotas.py#L442

  [1] -
  https://github.com/openstack/horizon/blob/4570b4cd7813c5b5d559a87c715f4ee6e6f1f63d/horizon/utils/memoized.py#L88

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1700578/+subscriptions