yahoo-eng-team team mailing list archive

[Alex Xu <soulxu@xxxxxxxxx>]

Public bug reported:

The JSON-Schema support to validate the input for the legacy v2
compatible mode, and for the legacy v2 request, it won't return 400 for
extra invalid parameters, instead by filter the extra parameters out of
the input body to protect the API break by the extra parameters.

https://github.com/openstack/nova/blob/68bbddd8aea8f8b2d671e0d675524a1e568eb773/nova/api/openstack/compute/evacuate.py#L75

https://github.com/openstack/nova/blob/68bbddd8aea8f8b2d671e0d675524a1e568eb773/nova/api/openstack/compute/migrate_server.py#L66

https://github.com/openstack/nova/blob/68bbddd8aea8f8b2d671e0d675524a1e568eb773/nova/api/openstack/compute/server_groups.py#L166

Those should be fixed to cover the legacy v2 request, and back-port the
fix.

** Affects: nova
     Importance: Undecided
     Assignee: Alex Xu (xuhj)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Alex Xu (xuhj)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1701451

Title:
  some legacy v2 API lose the protection of json-schema

Status in OpenStack Compute (nova):
  New

Bug description:
  The JSON-Schema support to validate the input for the legacy v2
  compatible mode, and for the legacy v2 request, it won't return 400
  for extra invalid parameters, instead by filter the extra parameters
  out of the input body to protect the API break by the extra
  parameters.

  https://github.com/openstack/nova/blob/68bbddd8aea8f8b2d671e0d675524a1e568eb773/nova/api/openstack/compute/evacuate.py#L75

  https://github.com/openstack/nova/blob/68bbddd8aea8f8b2d671e0d675524a1e568eb773/nova/api/openstack/compute/migrate_server.py#L66

  https://github.com/openstack/nova/blob/68bbddd8aea8f8b2d671e0d675524a1e568eb773/nova/api/openstack/compute/server_groups.py#L166

  Those should be fixed to cover the legacy v2 request, and back-port
  the fix.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1701451/+subscriptions