yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #65544
[Bug 1688540] Re: When operation log enabled, logout returns "something went wrong"
Reviewed: https://review.openstack.org/462928
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2c94075bbe6d3c452af40b82eb5a50b10aa23fd9
Submitter: Jenkins
Branch: master
commit 2c94075bbe6d3c452af40b82eb5a50b10aa23fd9
Author: Mateusz Kowalski <mateusz.kowalski@xxxxxxx>
Date: Fri May 5 14:44:53 2017 +0200
operation_log: Fix logout generating AttributeError
When logging out request.user.is_authenticated() throws
AttributeError as request.user is NoneType and does not
contain required method.
This patch checks whether request.user is None and
takes a proper action.
Change-Id: Iaef08139e6f5c4c0e886328a16a7ac442acc1c10
Closes-Bug: #1688540
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1688540
Title:
When operation log enabled, logout returns "something went wrong"
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
When operation log enabled, logout returns "something went wrong" with
the following stacktrace:
2017-05-05 14:25:11,882 16560 ERROR django.request Internal Server Error: /auth/logout/
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 223, in get_response
response = middleware_method(request, response)
File "/usr/lib/python2.7/site-packages/horizon/middleware/operation_log.py", line 78, in process_response
log_format = self._get_log_format(request)
File "/usr/lib/python2.7/site-packages/horizon/middleware/operation_log.py", line 113, in _get_log_format
request.user.is_authenticated()):
AttributeError: 'NoneType' object has no attribute 'is_authenticated'
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1688540/+subscriptions
References