← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1697960] Re: enable_new_services=False should only auto-disable nova-compute services

 

Reviewed:  https://review.openstack.org/474285
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=38cca9d90506a577025a4bc2c9b023f54123a252
Submitter: Jenkins
Branch:    master

commit 38cca9d90506a577025a4bc2c9b023f54123a252
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Wed Jun 14 12:38:35 2017 -0400

    Only auto-disable new nova-compute services
    
    Change If1e03c9343b8cc9c34bd51c2b4d25acdb21131ff made the
    os-services REST API only able to perform PUT actions on
    nova-compute services, since those are the only ones with
    host mappings in the API database. Attempting to enable or
    disable a nova-scheduler service, for example, will fail with a
    404 error now.
    
    The enable_new_services config option is used to auto-disable
    newly registered services to test them out before bringing them
    into the pool of services for scheduling. This was really only
    intended, and only makes sense for, nova-compute services. Disabling
    scheduler, conductor, or API services does nothing functionally, and
    requires the operator to later enable those services just to make
    the GET /os-services output make sense.
    
    This change makes the enable_new_services config option only have
    an effect on auto-disabling new nova-compute services. All other
    services are ignored and will not be auto-disabled. The config
    option help text is updated to make this clear.
    
    Change-Id: Ie9cb44d3f87ba85420e2909170f4d207ec4bf717
    Closes-Bug: #1697960


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1697960

Title:
  enable_new_services=False should only auto-disable nova-compute
  services

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  This came up in the mailing list:

  http://lists.openstack.org/pipermail/openstack-
  operators/2017-June/013765.html

  And was agreed that it can be considered a bug that the
  enable_new_services config option should only auto-disable new nova-
  compute services:

  http://lists.openstack.org/pipermail/openstack-
  operators/2017-June/013771.html

  It should not auto-disable things like nova-conductor, nova-scheduler
  or nova-osapi_compute, since (1) it doesn't make sense to disable
  those and (2) it just means the operator/admin has to enable them
  later to fix the nova service-list output.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1697960/+subscriptions


References