yahoo-eng-team team mailing list archive

[OpenStack Infra <1693168@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/467999
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=92e0efeefd6782f205dc6a2b1f8e8a97f146596d
Submitter: Jenkins
Branch:    master

commit 92e0efeefd6782f205dc6a2b1f8e8a97f146596d
Author: ghanshyam <ghanshyammann@xxxxxxxxx>
Date:   Thu Jul 6 08:58:48 2017 +0300

    Fix quota class set APIs
    
    v2.1 API which does not return the 'server_groups' and
    'server_group_members' quotas in GET & PUT os-quota-class-sets
    API response. v2 API used to return those keys in API response.
    
    Also filter out the network related quotas from os-quota-class-sets
    APIs
    
    Fixing this with microversion.
    Closes-Bug: #1701211
    Closes-Bug: #1693168
    implement-blueprint fix-quota-classes-api
    
    Change-Id: I66aeb7a92fb5ee906fead78030bd84a2e97916e8


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1693168

Title:
  Different APIs 'os-quota-class-sets' Response between v2 and v2.1

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  'os-quota-class-sets'  GET and PUT APIs response is different between v2(all extensions) and v2.1
  There is no 'server_groups' and 'server_group_members' in quota class set APIs response where these were present in v2 (with all extension).

  'os-server-group-quotas' extension was introduced in this -
    I78974602d4be04deaf173b3e43f2dab92e8f4171 in v2 API. 
  and if extension 'os-server-group-quotas' was enabled in v2, then 'server_groups' and 'server_group_members' were present in APIs response.
  This behavior was till we had the legacy_v2 code where this extensions class and way to enable/disable extensions was available. 

  In v2.1 API, there was never such extensions. v2.1 should behave same
  as v2 with all extensions. But we forgot to merge the if/else
  extension code[1] which caused 'server_groups' and
  'server_group_members' never showed up in quota class set APIs (GET
  and PUT) response.

  .. 1
  http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/quota_classes.py#n47

  This issue did not get caught on tests as legacy_v2 code got removed
  before functional tests with all extensions were enabled. And somehow
  sample file with 'server_groups' and 'server_group_members' attributes
  in response got disappeared while changing the directory structure
  v3->v2.1>/compute etc.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1693168/+subscriptions