yahoo-eng-team team mailing list archive

[OpenStack Infra <1704423@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/483986
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=da57d17e6c7d5d7e84af3c46a836ee587581bf8d
Submitter: Jenkins
Branch:    master

commit da57d17e6c7d5d7e84af3c46a836ee587581bf8d
Author: Balazs Gibizer <balazs.gibizer@xxxxxxxxxxxx>
Date:   Fri Jul 14 18:18:33 2017 +0200

    fix unshelve notification test instability
    
    The unshelve notification sample test shelve-offloads an instance, waits for
    it state to change to SHELVED_OFFLOADED then unshelve the instance and matches
    generated the unshelve notification with the stored sample. This test
    intermittently fails as the host paramter of the instance doesn't match
    sometimes. The reason is that the compute manager during shelve offloading
    first sets the state of the instance then later sets the host of the instance.
    So the test can start unshelving the instance before the host is cleaned by
    the shelve offload code.
    
    The test is updated to not just wait for the state change but also wait for
    the change of the host attribute.
    
    Change-Id: I459332de407187724fd2962effb7f3a34751f505
    Closes-Bug: #1704423


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1704423

Title:
  _test_unshelve_server intermittently fails in functional versioned
  notification tests

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  http://logs.openstack.org/39/483939/1/check/gate-nova-tox-functional-
  ubuntu-xenial/95a614f/console.html#_2017-07-14_14_16_48_905908

  None != u'compute': path: root.payload.nova_object.data.host

  Looks like we're racing between the time that the vm_state is set to
  SHELVED_OFFLOADED and the host is set to None:

  https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4446-L4457

  So the test should be waiting for the notification after the state
  change AND the instance.host is None.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1704423/+subscriptions