yahoo-eng-team team mailing list archive

[OpenStack Infra <1656183@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/420038
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=529dc665a06bb6f28a38830d974dd2302db3bda8
Submitter: Jenkins
Branch:    master

commit 529dc665a06bb6f28a38830d974dd2302db3bda8
Author: Ian Cordasco <graffatcolmingov@xxxxxxxxx>
Date:   Fri Jan 13 09:46:00 2017 -0600

    Satisfy API Reference documentation deleting tags
    
    The API Reference documentation for Glance v2 documents the response
    status code for the metadefs delete-tags call as 204, but instead that
    call returns a 200 status code. This patch fixes the disparity and adds
    the ability to start testing our response serializer.
    
    This patch changes the response code instead of the documentation
    because 204 (No Content) is the correct response for this call and
    because all the other metadefs DELETE calls return 204.  So to preserve
    consistency and to honor the published contract, this patch changes the
    code, not the documentation.
    
    This patch was discussed with the API-WG (on 2 Feb 2017) and the TC (on
    14 Feb 2017), and they both endorse this approach. See the meeting logs
    for details.
    
    Closes-bug: #1656183
    Depends-On: I84626976ca729f65b0ee0ea6afe5c9a6a408eecc
    Change-Id: I4b6dc1714aeca409a85bfa1f9b729147da704df8


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1656183

Title:
  Delete tags return 200 status code but api-ref says 204

Status in Glance:
  Fix Released

Bug description:
  delete tags API DELETE metadefs/namespaces/%s/tags actually return 200
  status code because response ResponseSerializer is not implemented for
  delete_tags in
  https://github.com/openstack/glance/blob/master/glance/api/v2/metadef_namespaces.py

  but api-ref below mentioned status code will be 204.

  http://developer.openstack.org/api-ref/image/v2/metadefs-
  index?expanded=delete-all-tag-definitions-detail#delete-all-tag-
  definitions

  Tests for tags are going to be added in tempest -
  https://review.openstack.org/#/c/403998/

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1656183/+subscriptions