yahoo-eng-team team mailing list archive

[OpenStack Infra <1593641@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/484201
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0d2daa262a785ebe8664c7cc761f79ef8b4a2661
Submitter: Jenkins
Branch:    master

commit 0d2daa262a785ebe8664c7cc761f79ef8b4a2661
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Sun Jul 16 09:17:35 2017 -0400

    XenAPI: Fix ValueError in test_slave_asks_master_to_add_slave_to_pool
    
    Change If9e8dd5cc2634168910d5f9f8d9302aeefa16097 in
    oslo.serialization will raise a ValueError when it can't
    convert something to a primitive, which in this case is the
    Aggregate object used in this test. Given the add_to_aggregate
    method doesn't even serialize the Aggregate object passed in,
    I'm not sure how this was working before, but the fix is to
    just not try and expect add_aggregate_host RPC API is called
    with a serialized Aggregate object.
    
    Change-Id: I139533dfd94a1aa7a00a6220a4411bebe1c9e88b
    Related-Bug: #1593641


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1593641

Title:
  Strange errors when using dump/dumps from jsonutils

Status in OpenStack Compute (nova):
  Fix Released
Status in oslo.serialization:
  Fix Released

Bug description:
  Methods dump/dumps throw strange exceptions (ValueError: Circular
  reference detected) when trying to serialize arbitrary (non-
  serializable) objects.

  For example,

  jsonutils.dumps(object())

  yields the following traceback:

  Traceback (most recent call last):
    File "/home/gdavoian/oslo.serialization/oslo_serialization/jsonutils.py", line 259, in <module>
      print dumps(object())
    File "/home/gdavoian/oslo.serialization/oslo_serialization/jsonutils.py", line 184, in dumps
      return json.dumps(obj, default=default, **kwargs)
    File "/usr/lib/python2.7/json/__init__.py", line 250, in dumps
      sort_keys=sort_keys, **kw).encode(obj)
    File "/usr/lib/python2.7/json/encoder.py", line 207, in encode
      chunks = self.iterencode(o, _one_shot=True)
    File "/usr/lib/python2.7/json/encoder.py", line 270, in iterencode
      return _iterencode(o, 0)
  ValueError: Circular reference detected

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1593641/+subscriptions