yahoo-eng-team team mailing list archive

[OpenStack Infra <1687187@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/480765
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b7cb3b7523b70dd94135f07b6307fa48563119f8
Submitter: Jenkins
Branch:    master

commit b7cb3b7523b70dd94135f07b6307fa48563119f8
Author: Michael Still <mikal@xxxxxxxxxxx>
Date:   Tue Jul 4 18:19:44 2017 +1000

    Only setup iptables for metadata if using nova-net
    
    As discussed in the bug report, we setup iptables rules for the metadata
    service even if we're using neutron (which routes to metadata in a
    different way). This is because of the split-brain behaviour of the
    network driver interface versus the network API interface.
    
    Instead, only setup iptables if we are _not_ using neutron.
    
    Change-Id: I43df9200aba1018d2c7cd2f118864326af15fd42
    Closes-Bug: #1687187


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1687187

Title:
  metadata-api requires iptables-save/restore

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The metadata-api still loads pieces of nova-network even when using
  neutron=True.

  Specifically, it is still loading linuxnet_interface_driver and it is
  adding in ACCEPT rules with iptables to allow the metadata port. While
  this may make sense with nova-network, it doesn't make sense for an
  api to be messing with iptables.

  Since neutron uses metadata-api through its proxy, it cannot be said
  that the metadata-api is purely a nova-network thing.

  The MetadataManager class that is loaded makes note of the fact that
  all the class does is add that ACCEPT rule [0]. Previously in Newton I
  was able to work around this by overriding the MetadataManager class
  with 'nova.manager.Manager', that that option was removed in Ocata
  [1]. Now the 'nova.api.manager.MetadataManager' name is hardcoded [2]
  and requires modifying nova source.

  TL;DR when using the metadata-api, bits of nova-network are still
  loaded when they shouldn't be.

  [0]
  https://github.com/openstack/nova/blob/4f91ed3a547965ed96a22520edcfb783e7936e95/nova/api/manager.py#L24

  [1]
  https://github.com/openstack/nova/blob/stable/newton/nova/conf/service.py#L51

  [2]
  https://github.com/openstack/nova/blob/065cd6a8d69c1ec862e5b402a3150131f35b2420/nova/service.py#L60

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1687187/+subscriptions