yahoo-eng-team team mailing list archive

[IWAMOTO Toshihiro <iwamoto@xxxxxxxxxxxxx>]

Public bug reported:

The current code is:

    @contextlib.contextmanager
    def defer_apply(self):
        """Defer apply context."""
        self.filter_defer_apply_on()
        try:
            yield
        finally:
            self.filter_defer_apply_off()

This means filter_defer_apply_off will be called even if there is an
exception and the exception will be reraised.

Assuming the SG rules were consistent before this contextmanager call,
it might make more sense to just discard deferred SG programming.

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: sg-fw

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1706285

Title:
  FirewallDriver's defer_apply might need better exception handling

Status in neutron:
  New

Bug description:
  The current code is:

      @contextlib.contextmanager
      def defer_apply(self):
          """Defer apply context."""
          self.filter_defer_apply_on()
          try:
              yield
          finally:
              self.filter_defer_apply_off()

  This means filter_defer_apply_off will be called even if there is an
  exception and the exception will be reraised.

  Assuming the SG rules were consistent before this contextmanager call,
  it might make more sense to just discard deferred SG programming.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1706285/+subscriptions