yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #66126
[Bug 1564543] Re: It is impossible to access assets of the theme not present in AVAILABLE_THEMES
Reviewed: https://review.openstack.org/317757
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=958e522d402615779609b5d660a545198cfa8a28
Submitter: Jenkins
Branch: master
commit 958e522d402615779609b5d660a545198cfa8a28
Author: Diana Whitten <hurgleburgler@xxxxxxxxx>
Date: Tue May 17 15:06:05 2016 -0700
Added SELECTABLE_THEMES setting
Currently themes machinery works in such way that if we rely on
default theme in our branded theme, we have to include them both into
AVAILABLE_THEMES setting, otherwise default theme assets will be
unavailable and the branded theme assets compilation will fail. On
the other hand, mentioning them both leads to theme picker being
shown - which we would like to avoid (per marketing wish).
SELECTABLE_THEMES setting was added to allow limiting the user facing
themes by configuration.
Closes-bug: #1564543
Co-Authored-By: Ivan Kolodyazhny <e0ne@xxxxxxxxx>
Change-Id: Ic00a9201d2d352685b1089a37a25987b75d6636d
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1564543
Title:
It is impossible to access assets of the theme not present in
AVAILABLE_THEMES
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
Currently themes machinery works in such way that if we rely on
default theme in our branded theme, we have to include them both into
AVAILABLE_THEMES setting, otherwise default theme assets will be
unavailable and the branded theme assets compilation will fail. On the
other hand, mentioning them both leads to theme picker being shown -
which we would like to avoid (per marketing wish). Is it possible to
show less themes for switching (ideally, one) and still be able to
reference other themes assets?
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1564543/+subscriptions
References