yahoo-eng-team team mailing list archive

[OpenStack Infra <1707660@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/489248
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5b53b8c17d3b55ead2b3828c90245b3a8ac91c6e
Submitter: Jenkins
Branch:    master

commit 5b53b8c17d3b55ead2b3828c90245b3a8ac91c6e
Author: Luigi Toscano <ltoscano@xxxxxxxxxx>
Date:   Mon Jul 31 16:47:14 2017 +0200

    Pass renderer to SelectWidget.render()
    
    Required for Django 1.11 compatibility. Apparently
    DynamicSelectWidget.render() receives it (through kwargs) and
    tries to pass the parameter to its parent's method, but then
    it fails (leading to exceptions in the rendering).
    
    Closes-Bug: #1707660
    Change-Id: I25e294a1c2f721a2f57dd50acb4c5e408b6187f9


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1707660

Title:
  DynamicSelectWidget.render()/SelectWidget.render() interation
  incompatible with Django 1.11

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  DynamicSelectWidget has a render method:
   def render(self, *args, **kwargs):

  which seems to receive a renderer argument starting from Django 1.11
  (see the signature of render() from
  https://docs.djangoproject.com/en/1.11/ref/forms/widgets/#widget).

  Then the render() method of the parent (SelectWidget) class is called,
  but it does not accept renderer:

  def render(self, name, value, attrs=None, renderer=None):

  This produces a warning and a template rendering failure when
  DynamicSelectWidget is used, like in sahara_dashboard:

    File "/home/jenkins/workspace/gate-sahara-dashboard-python27-ubuntu-xenial/.tox/py27/src/openstack/horizon/horizon/forms/fields.py", line 360, in render
      return super(DynamicSelectWidget, self).render(*args, **kwargs)
  TypeError: render() got an unexpected keyword argument 'renderer'
  WARNING:django.template:Exception raised while rendering {% include %} for template 'horizon/common/_workflow_step.html'. Empty string rendered instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1707660/+subscriptions