yahoo-eng-team team mailing list archive

[OpenStack Infra <1707669@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/489273
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=afab0ca0c8f4c68b8d6d8646f408e9522596870e
Submitter: Jenkins
Branch:    master

commit afab0ca0c8f4c68b8d6d8646f408e9522596870e
Author: Jay Pipes <jaypipes@xxxxxxxxx>
Date:   Mon Jul 31 12:28:38 2017 -0400

    placement: remove existing allocs when set allocs
    
    Bug #1707669 highlighted a situation that arose when attempting to
    remove part of an allocation for a source host during a resize
    operation where the exiting allocation was not being properly deleted.
    
    In this patch, we remove the part of the WHERE condition that limited
    deleted allocation records to only those referring to a particular
    resource provider. In doing so, we make the creation of an allocation
    for a consumer a proper overwrite operation.
    
    Change-Id: I0835e5b4f22277465012aab9a5bf474608cb533b
    Fixes-bug: #1707669


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1707669

Title:
  [placement] put allocations does not do a full overwrite of existing
  allocations

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The presumption all along has been that when doing a PUT
  /allocations/{consumer_uuid} that the body of that request would fully
  replace any allocations associated with that consumer.

  This has turned out not to be the case. The code [1] to clean up the
  current allocations was only deleting allocations where the consumer
  _and_ resource provider matched the incoming allocations. We want to
  wipe the slate.

  Huge hat tip to gibi for doing the necessary digging to get this
  going.

  [1]
  https://github.com/openstack/nova/blob/master/nova/objects/resource_provider.py#L1509-L1520

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1707669/+subscriptions