yahoo-eng-team team mailing list archive

[OpenStack Infra <1707238@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/488545
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d39934ad6afb7e2729bb45235f363ada86012d15
Submitter: Jenkins
Branch:    master

commit d39934ad6afb7e2729bb45235f363ada86012d15
Author: melanie witt <melwittt@xxxxxxxxx>
Date:   Fri Jul 28 17:06:53 2017 +0000

    Detach device from live domain even if not found on persistent
    
    In a past attempt to fix a bug [1], we started raising DeviceNotFound
    if a device wasn't found on the persistent domain. This was to address
    a scenario where the guest ignored the detach from the live domain
    because it was busy and we wanted to avoid failing a later detach
    request to the user (compute handles DeviceNotFound).
    
    Unfortunately, in the above case, a later detach request won't fail to
    the user but it also won't detach from the live domain. It sees the
    device already detached from the persistent domain and doesn't attempt
    to detach from the live domain.
    
    This is a serious problem because it's possible for a volume to be
    attached to two live domains and data corruption can occur.
    
    This adds an attempt to detach from the live domain even if we had
    already detached from the persistent domain in the past.
    
    Closes-Bug: #1707238
    
    [1] https://review.openstack.org/386257
    
    Change-Id: I8cd056fa17184a98c31547add0e9fb2d363d0908


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1707238

Title:
  detach_device_with_retry doesn't detach from live domain if persistent
  domain was already detached in the past

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) newton series:
  Confirmed
Status in OpenStack Compute (nova) ocata series:
  Confirmed

Bug description:
  In an attempt to fix a different bug [1] where a later try to detach a
  volume failed if the guest was busy and ignored the request to detach
  from the live domain, a new bug was introduced where a later try to
  detach a volume silently passes even though the device is still
  attached to the live domain.

  This bug is serious because now it's possible for a volume to be
  attached to two live domains and data corruption can occur. We should
  be trying to detach from the live domain even if we had already
  detached from the persistent domain in the past.

  [1] https://bugs.launchpad.net/nova/+bug/1633236

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1707238/+subscriptions