yahoo-eng-team team mailing list archive

[OpenStack Infra <1706348@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/487107
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0c1e179b3cac854552c7f13f1226cd187e20a75a
Submitter: Jenkins
Branch:    master

commit 0c1e179b3cac854552c7f13f1226cd187e20a75a
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Tue Jul 25 13:49:05 2017 +0000

    api.rest.neutron: Ensure dict is passed to api.neutron args
    
    Some functions in api/neutron use @memoized decorator,
    but @memoized decorator cannot handle request.GET (an instance of
    QueryDict) because a weakref to WSGIRequest is not hashable.
    (Note that @memoized decorator can handle a dict itself)
    
    What we actually need is the content of request.GET.
    By using .dict() method we can ensure arguments which
    @memoized can handle are passed to api.neutron functions.
    
    This pattern is used only in api.rest.neutron and
    not used in other codes.
    
    Closes-Bug: #1706348
    Change-Id: Ibb38ad1d95af1cd90a1fedd834602f444010c151


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1706348

Title:
  UnhashableKeyWarning when opening Angular Launch Instance form

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  When opening Angular Launch Instance form, I see the following warning
  from @memoized decorator.

  It happens because request.GET QueryDict object is passed and it is
  not hashable. memoized decorator expects hashable parameters.

  [25/Jul/2017 13:43:33] "GET /api/neutron/networks/ HTTP/1.1" 200 2132
  UnhashableKeyWarning: The key ((<weakref at 0x7f08a338f260; to 'WSGIRequest' at 0x7f08a1136650>,), ((u'network_id', [u'cee8181f-bb45-428c-96b7-3e4d05e8d9ee']),)) is not hashable and cannot be memoized.
  WARNING:py.warnings:UnhashableKeyWarning: The key ((<weakref at 0x7f08a338f260; to 'WSGIRequest' at 0x7f08a1136650>,), ((u'network_id', [u'cee8181f-bb45-428c-96b7-3e4d05e8d9ee']),)) is not hashable and cannot be memoized.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1706348/+subscriptions