yahoo-eng-team team mailing list archive

[OpenStack Infra <1710131@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/493335
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=00f74fc06c37c58c23ff00ee9f36048d158ceeb1
Submitter: Jenkins
Branch:    master

commit 00f74fc06c37c58c23ff00ee9f36048d158ceeb1
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Sat Aug 12 22:30:13 2017 +0000

    Revert "Generate language list automatically"
    
    This reverts commit a88092630014c53c9e6fe4ee9265f8443eea96bd.
    
    The reverted implementation depends on LOCALE_PATHS but this assumption
    turns out not correct. Django searches messages catalogs LOCALE_PATHS
    and locale directory in individual INSTALLED_APPS, but the usage of
    LOCALE_PATHS varies on deployers and we cannot assume the default value
    of LOCALE_PATSH.
    
    In addition, the logic of auto-generating the language list cannot
    handle locale name alias ('fallback' in the Django code).
    Django 1.9 or later perfers to zh-hant and zh-hans, and zh-cn and
    zh-tw are now defined as fallback.
    
    We can explore a better approach for auto-generation of the language
    list, but we do not have more reliable way so far. Cconsidering the
    timing of Pike release, the safest approach looks like to revert
    the original patch back to the manula maintenance of the lang list.
    
    Languages with over 50% progress (based on the number of translated
    messages as total) are listed in settings.LANGUAGES.
    (http://paste.openstack.org/show/618254/)
    
    Closes-Bug: #1710131
    Change-Id: I5133d6317aba6107fc37bd5f30388c130b1fdaac


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1710131

Title:
  auto generation of language list does not work expected

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  During Pike cycle, we introduced a mechanism to auto-generate the
  language list based on PO file availability [1].

  However we received a couple of bug reports which seem to be triggered
  by this change.

  One is "can't change the language in user settings" and only "English"
  is available in the user setting menu [2]. Note that all messages are
  displayed in a local language so it is just a problem in the
  generation logic of the language list.

  Another report is Simplified Chinese is not available in the language
  list [3].

  It looks better to revert the change [3]. It turns out there are
  several cases the patch did not assume when it was implemented.

  [1] https://review.openstack.org/#/c/450126/
  [2] http://eavesdrop.openstack.org/irclogs/%23openstack-i18n/%23openstack-i18n.2017-08-03.log.html#t2017-08-03T14:05:05
  [3] http://lists.openstack.org/pipermail/openstack-i18n/2017-August/003017.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1710131/+subscriptions