yahoo-eng-team team mailing list archive

[OpenStack Infra <1712025@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/494445
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c6c24eda59f8203f112125a4d1c073158576dd6b
Submitter: Jenkins
Branch:    master

commit c6c24eda59f8203f112125a4d1c073158576dd6b
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Thu Aug 17 08:43:44 2017 +0000

    Make icmp_type/code optional
    
    In Neutron API icmp_type/code are not required fields,
    so they should be optional.
    
    Previously we support Nova API which requires icmp_type
    and icmp_code but we dropped Nova security group API support in Pike
    and we no longer need to care it.
    
    Change-Id: Ie460e763928b4f50f84c38d88556df632078ba42
    Closes-Bug: #1712025


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1712025

Title:
  ICMP type/code should be optional in Security Group creation form

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In the "Add Rule" (security group) form, when "Custom ICMP rule" is
  selected, "Type" and "Code" are both marked as required. In Neutron
  API, ICMP rule can be created without specifying both ICMP type and
  code.

  You can create
  - an ICMP rule without ICMP type and ICMP code
  - and ICMP rule only with ICMP type

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1712025/+subscriptions