yahoo-eng-team team mailing list archive

[OpenStack Infra <1713150@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/498094
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=27cd4dd70b5a51919ce0091ab4247f65e5a27526
Submitter: Jenkins
Branch:    master

commit 27cd4dd70b5a51919ce0091ab4247f65e5a27526
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Fri Aug 25 17:13:48 2017 -0400

    Change default for [notifications]/default_publisher_id to $host
    
    The default used in code for CONF.notifications.default_publisher_id
    is CONF.host, which is a free-form StrOpt.
    
    In an upcoming change, the "my_ip" option is going to be changed from
    a StrOpt to an IPOpt, so we made the default value change for
    the default_publisher_id option before that.
    
    Change-Id: Ia85130f66bd5a60097e8967064559fd0962d06fd
    Closes-Bug: #1713150


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1713150

Title:
  config option help for default value of default_publisher_id is wrong

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The config option help for "default_publisher_id" says the default
  value is "$my_ip" but that's not what's actually used:

          notifier = rpc.get_notifier('api', publisher_id=(
              CONF.notifications.default_publisher_id or CONF.host))

  and:

      if not publisher_id:
          publisher_id = "%s.%s" % (service, host or CONF.host)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1713150/+subscriptions