yahoo-eng-team team mailing list archive

[Abhilash S <1714007@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

_verify_gateway_port() has the following code, which seems to be trying
to assert that the fixed ip of the port on the router is allocated from
an appropriate public subnet. Since it only takes the first subnet of
the public network, this will always fail if the ip of the port is in a
different subnet.

        public_net_body = self.admin_client.show_network(
            CONF.network.public_network_id)
        public_subnet_id = public_net_body['network']['subnets'][0]
        self.assertIn(public_subnet_id,
                      [x['subnet_id'] for x in fixed_ips])

Similar bug: https://bugs.launchpad.net/tempest/+bug/1624057
The above bug has been fixed in openstack/tempest 14.0 onwards, however bug fix for same tests are not reflected under openstack/neutron tests.

This causes the following neutron tests to fail when having multiple
public subnets :

neutron.tests.tempest.api.test_routers.RoutersTest.test_update_router_set_gateway_with_snat_explicit
neutron.tests.tempest.api.test_routers.RoutersTest.test_update_router_set_gateway_without_snat
neutron.tests.tempest.api.test_routers.RoutersTest.test_update_router_reset_gateway_without_snat

** Affects: neutron
     Importance: Undecided
         Status: New


** Tags: neutron tempest

** Summary changed:

- Incorrect assert in test_routers._verify_gateway_port
+ Incorrect assert in test_routers._verify_gateway_port  under neutron tests

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1714007

Title:
  Incorrect assert in test_routers._verify_gateway_port  under neutron
  tests

Status in neutron:
  New

Bug description:
  _verify_gateway_port() has the following code, which seems to be
  trying to assert that the fixed ip of the port on the router is
  allocated from an appropriate public subnet. Since it only takes the
  first subnet of the public network, this will always fail if the ip of
  the port is in a different subnet.

          public_net_body = self.admin_client.show_network(
              CONF.network.public_network_id)
          public_subnet_id = public_net_body['network']['subnets'][0]
          self.assertIn(public_subnet_id,
                        [x['subnet_id'] for x in fixed_ips])

  Similar bug: https://bugs.launchpad.net/tempest/+bug/1624057
  The above bug has been fixed in openstack/tempest 14.0 onwards, however bug fix for same tests are not reflected under openstack/neutron tests.

  This causes the following neutron tests to fail when having multiple
  public subnets :

  neutron.tests.tempest.api.test_routers.RoutersTest.test_update_router_set_gateway_with_snat_explicit
  neutron.tests.tempest.api.test_routers.RoutersTest.test_update_router_set_gateway_without_snat
  neutron.tests.tempest.api.test_routers.RoutersTest.test_update_router_reset_gateway_without_snat

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1714007/+subscriptions