← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1608980] Re: Remove MANIFEST.in as it is not explicitly needed by PBR

 

Reviewed:  https://review.openstack.org/499409
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=33a43f7d54fee141479b0ec61426a4ae8972c62d
Submitter: Jenkins
Branch:    master

commit 33a43f7d54fee141479b0ec61426a4ae8972c62d
Author: luqitao <qtlu@xxxxxxxxxxxxx>
Date:   Thu Aug 31 09:23:31 2017 +0800

    Drop MANIFEST.in - it's not needed by pbr
    
    Tacker already uses PBR:-
    setuptools.setup(
        setup_requires=['pbr>=2.0.0'],
        pbr=True)
    
    This patch removes `MANIFEST.in` file as pbr generates a
    sensible manifest from git files and some standard files
    and it removes the need for an explicit `MANIFEST.in` file.
    
    Change-Id: Ia90ea3018b42c2536af899af77de9c4c651c9b6f
    Closes-Bug: #1608980


** Changed in: tacker
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1608980

Title:
  Remove MANIFEST.in as it is not explicitly needed by PBR

Status in anvil:
  Invalid
Status in networking-bgpvpn:
  In Progress
Status in craton:
  Fix Released
Status in DragonFlow:
  Fix Released
Status in ec2-api:
  Fix Released
Status in gce-api:
  Fix Released
Status in Glance:
  Fix Released
Status in Karbor:
  Fix Released
Status in OpenStack Identity (keystone):
  Fix Released
Status in keystoneauth:
  Fix Released
Status in keystonemiddleware:
  Fix Released
Status in Kosmos:
  Fix Released
Status in Magnum:
  Fix Released
Status in masakari:
  Fix Released
Status in BaGPipe:
  Fix Released
Status in networking-midonet:
  Fix Released
Status in networking-odl:
  Fix Released
Status in neutron:
  Fix Released
Status in Neutron LBaaS Dashboard:
  Fix Released
Status in octavia:
  Fix Released
Status in os-vif:
  Fix Released
Status in python-searchlightclient:
  In Progress
Status in OpenStack Search (Searchlight):
  Fix Released
Status in Solum:
  Fix Released
Status in storlets:
  In Progress
Status in Swift Authentication:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tacker:
  Fix Released
Status in Tricircle:
  Fix Released
Status in OpenStack DBaaS (Trove):
  Fix Released
Status in watcher:
  Fix Released
Status in Zun:
  Fix Released

Bug description:
  PBR do not explicitly require MANIFEST.in, so it can be removed.

  
  Snippet from: http://docs.openstack.org/infra/manual/developers.html

  Manifest

  Just like AUTHORS and ChangeLog, why keep a list of files you wish to
  include when you can find many of these in git. MANIFEST.in generation
  ensures almost all files stored in git, with the exception of
  .gitignore, .gitreview and .pyc files, are automatically included in
  your distribution. In addition, the generated AUTHORS and ChangeLog
  files are also included. In many cases, this removes the need for an
  explicit ‘MANIFEST.in’ file

To manage notifications about this bug go to:
https://bugs.launchpad.net/anvil/+bug/1608980/+subscriptions