yahoo-eng-team team mailing list archive

[OpenStack Infra <1508568@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/241224
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3a99499ba0adafd1e64262a5ba63ae94b1f05cf0
Submitter: Jenkins
Branch:    master

commit 3a99499ba0adafd1e64262a5ba63ae94b1f05cf0
Author: Ivan Kolodyazhny <e0ne@xxxxxxxxx>
Date:   Wed May 24 13:00:46 2017 +0300

    Get all needed instances for volumes attachments at Admin->Volumes
    
    Nova server_list() wrapper needs to receive an explicit `all_tenants`
    boolean flag in order to request instances for _all_ tenants -
    otherwise while rendering Admin->Volumes table Django will request
    missing instances (to get their names for volume attachments) one by
    one, thus significantly increasing response time.
    
    This patch adds check if all_tenants in search_opts and add it to
    the search else uses tenant_id in the search_opts.
    
    Co-Authored-By: Dmitry Sutyagin <dsutyagin@xxxxxxxxxxxx>
    Co-Authored-By: Ivan Kolodyazhny <e0ne@xxxxxxxxx>
    Change-Id: I4761d7da15036b69619649871aef91e1799ee385
    Closes-Bug: #1508568


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1508568

Title:
  get_attachment_name() makes a lot of unnecessary calls to Nova

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Due to some unexpected condition the `else` branch here
  https://github.com/openstack/horizon/blob/stable/juno/openstack_dashboard/dashboards/project/volumes/volumes/tables.py#L268
  is often hit, this causes a lot of requests to Nova made while
  rendering Admin->Volumes panel (even with all required instances
  already collected one time).

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1508568/+subscriptions