← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1715470] Re: test_rpc_consumer_isolation fails with oslo.messaging 5.31.0

 

Reviewed:  https://review.openstack.org/501385
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=bd1e2fd60ff6c694b9daf2373b3f508b6274e15f
Submitter: Jenkins
Branch:    master

commit bd1e2fd60ff6c694b9daf2373b3f508b6274e15f
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Wed Sep 6 15:12:45 2017 -0400

    Fix test_rpc_consumer_isolation for oslo.messaging 5.31.0
    
    With this change in oslo.messaging 5.31.0:
    
      I0bbf9fca0ecbe71efa87c9613ffd32eb718f2c0e
    
    The endpoint passed in is going to be checked for a 'target'
    attribute and check it's type if set, so looking for it has
    to be ignored.
    
    Change-Id: Ic022bdc0291ce1498abdfe1acd3cc51adf7db7c6
    Closes-Bug: #1715470


** Changed in: cinder
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1715470

Title:
  test_rpc_consumer_isolation fails with oslo.messaging 5.31.0

Status in Cinder:
  Fix Released
Status in OpenStack Compute (nova):
  In Progress

Bug description:
  Seen in this upper-constraints change:

  http://logs.openstack.org/70/500770/9/check/gate-cross-cinder-python27
  -ubuntu-xenial/1b40c85/console.html#_2017-09-06_18_33_51_290254

  2017-09-06 18:33:51.290254 | cinder.tests.unit.test_test.IsolationTestCase.test_rpc_consumer_isolation
  2017-09-06 18:33:51.290274 | -------------------------------------------------------------------------
  2017-09-06 18:33:51.290280 | 
  2017-09-06 18:33:51.290289 | Captured traceback:
  2017-09-06 18:33:51.290298 | ~~~~~~~~~~~~~~~~~~~
  2017-09-06 18:33:51.290311 |     Traceback (most recent call last):
  2017-09-06 18:33:51.290334 |       File "cinder/tests/unit/test_test.py", line 46, in test_rpc_consumer_isolation
  2017-09-06 18:33:51.290348 |         endpoints=[NeverCalled()])
  2017-09-06 18:33:51.290364 |       File "cinder/rpc.py", line 159, in get_server
  2017-09-06 18:33:51.290377 |         access_policy=access_policy)
  2017-09-06 18:33:51.290418 |       File "/home/jenkins/workspace/gate-cross-cinder-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/debtcollector/updating.py", line 64, in wrapper
  2017-09-06 18:33:51.290433 |         return wrapped(*args, **kwargs)
  2017-09-06 18:33:51.290475 |       File "/home/jenkins/workspace/gate-cross-cinder-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_messaging/rpc/server.py", line 214, in get_rpc_server
  2017-09-06 18:33:51.290486 |         access_policy)
  2017-09-06 18:33:51.290527 |       File "/home/jenkins/workspace/gate-cross-cinder-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/oslo_messaging/rpc/dispatcher.py", line 155, in __init__
  2017-09-06 18:33:51.290555 |         target = getattr(ep, 'target', None)
  2017-09-06 18:33:51.290576 |       File "cinder/tests/unit/test_test.py", line 42, in __getattribute__
  2017-09-06 18:33:51.290592 |         self.fail(msg="I should never get called.")
  2017-09-06 18:33:51.290648 |       File "/home/jenkins/workspace/gate-cross-cinder-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/unittest2/case.py", line 690, in fail
  2017-09-06 18:33:51.290666 |         raise self.failureException(msg)
  2017-09-06 18:33:51.290681 |     AssertionError: I should never get called.

  https://github.com/openstack/oslo.messaging/compare/5.30.0...5.31.0

  My guess is this change breaks the test:

  https://github.com/openstack/oslo.messaging/commit/b7382d58d773e9be61dda3fac5b2e3cbddc22a22

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1715470/+subscriptions