yahoo-eng-team team mailing list archive

[OpenStack Infra <1715462@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/501408
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bf0f5d475458a67a12000ff49a8c5285c3ac9e45
Submitter: Jenkins
Branch:    master

commit bf0f5d475458a67a12000ff49a8c5285c3ac9e45
Author: Mohammed Naser <mnaser@xxxxxxxxxxxx>
Date:   Wed Sep 6 15:19:01 2017 -0400

    Ensure instance mapping is updated in case of quota recheck fails
    
    If an instance fails to successfully pass the quota recheck, it will
    raise a TooManyInstances exception, however, it will not hit the
    code which saves the instance mapping, leaving an instance with no
    assigned cell in the mapping table and no BuildRequest as it is
    removed by _cleanup_build_artifacts.
    
    This patch adds a test to make sure that an instance has the correct
    cell mapping if it fails in the quota recheck phase.  In addition, it
    uses the cell_mapping_cache dictionary to set the correct cell
    mapping before marking the instance as ERROR.
    
    Co-Authored-By: Dan Smith <dansmith@xxxxxxxxxx>
    Co-Authored-By: Matt Riedemann <mriedem.os@xxxxxxxxx>
    Co-Authored-By: melanie witt <melwittt@xxxxxxxxx>
    Closes-Bug: #1715462
    
    Change-Id: I7ecb5feb47a5f358cd51bde87b75a3a6141b5b12


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1715462

Title:
  Instances failing quota recheck end up with no assigned cell

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) pike series:
  Confirmed

Bug description:
  When an instance fails the quota rechecks codebase which is here:

  https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L992-L1006

  It raises an exception, however, the cell mapping is only saved much
  later (thanks help of dansmith for finding this):

  https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L1037-L1043

  This results in an instance with an unassigned cell, where it should
  technically be the cell it was scheduled into.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1715462/+subscriptions