yahoo-eng-team team mailing list archive

[OpenStack Infra <1680161@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/453786
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=f8a86e74f108aee8cba8a3fdde0a9267bd892d4a
Submitter: Jenkins
Branch:    master

commit f8a86e74f108aee8cba8a3fdde0a9267bd892d4a
Author: Yushiro FURUKAWA <y.furukawa_2@xxxxxxxxxxxxxx>
Date:   Thu Apr 6 01:55:54 2017 +0900

    Fix filtering parameter to get firewall_group
    
    This commit fixes query filtering in order to get firewall_group
    from firewall_policy_id as following:
    
        'ingress_firewall_policy_id' or 'egress_firewall_policy_id'
    
    Change-Id: I447ac09347d91b0c2712a8026df4e45aaa72a5e1
    Closes-Bug: #1680161


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1680161

Title:
  FWaaS v2 - filtering doesn't work correctly

Status in neutron:
  Fix Released

Bug description:
  In FWaaS v2, when firewall-policy tries to update public from True to False,
  following validation expect to work:

    1. Get firewall group object which includes the firewall-policy as
       'ingress_firewall_policy_id' or 'egress_firewall_policy_id'
    2. Verify whether the firewall-group belongs same project or not

  Currently, filter is wrong.  Therefore, it should be fixed:
  However, this bug doesn't occur because following bug hasn't fixed yet so it's not urgent bug:

      https://bugs.launchpad.net/neutron/+bug/1657190

    Before:

      filters = {
          'ingress_firewall_rule_id': [fwp_id],
          'ingress_firewall_rule_id': [fwp_id]
      }

    After:

      filters = {
          'ingress_firewall_policy_id': [fwp_id],
          'egress_firewall_policy_id': [fwp_id]
      }

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1680161/+subscriptions